Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude exe_running_docker_save in the "Update Package Repository" rule #948

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Exclude exe_running_docker_save in the "Update Package Repository" rule #948

merged 2 commits into from
Dec 4, 2019

Conversation

JPLachance
Copy link
Contributor

@JPLachance JPLachance commented Dec 3, 2019

What type of PR is this?
/kind bug
/kind rule-update

Any specific area of the project related to this PR?
/area rules

What this PR does / why we need it:
The "Update Package Repository" gets fired each time we launch a container.

{
    "output": "13:50:21.811741662: Notice Repository files get updated (user=root command=exe /var/lib/docker/overlay2/c8a17dac80b37bf1911335032d83ab0be5805fad1ddc02cfa6d591fd96de4927/diff file=/etc/yum.repos.d/CentOS-fasttrack.repo container_id=host image=<NA>) k8s.ns=<NA> k8s.pod=<NA> container=host k8s.ns=<NA> k8s.pod=<NA> container=host",
    "priority": "Notice",
    "output_fields": {
      "container.id": "host",
      "fd.name": "/etc/yum.repos.d/CentOS-fasttrack.repo",
      "proc.cmdline": "exe /var/lib/docker/overlay2/c8a17dac80b37bf1911335032d83ab0be5805fad1ddc02cfa6d591fd96de4927/diff",
      "user.name": "root",
      "evt.time": 1574949021811741700
    },
    "rule": "Update Package Repository"
  }

This event is surrounded by dozens like it.

Adding a simple and not exe_running_docker_save fixes the issue.

Which issue(s) this PR fixes:
I did not file an issue, here is the PR instead!

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules(Update Package Repository): fixed a false positive by excluding "exe_running_docker_save". 

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Could you please reword the commit message (removing the ! at the start) ?

Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
@JPLachance JPLachance requested a review from leodido December 3, 2019 21:31
@poiana
Copy link
Contributor

poiana commented Dec 3, 2019

LGTM label has been added.

Git tree hash: 8f544daae218e3f8b0e11dc23727c7e7e679a742

@Kaizhe
Copy link
Contributor

Kaizhe commented Dec 4, 2019

/lgtm

@poiana
Copy link
Contributor

poiana commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido merged commit 418bcf2 into falcosecurity:dev Dec 4, 2019
@leodido
Copy link
Member

leodido commented Dec 4, 2019

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Dec 4, 2019
@JPLachance JPLachance deleted the fix-exe-docker-save-update-package-repo branch February 4, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants