Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic builds (mostly) #968

Merged
merged 77 commits into from
Jan 17, 2020
Merged

Dynamic builds (mostly) #968

merged 77 commits into from
Jan 17, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Dec 10, 2019

Signed-off-by: Lorenzo Fontana lo@linux.com

Work items

  • Change cmake files to build dynamically most of the dependencies (not every dependency can be linked dynamically because some of them are not OS packaged e.g OpenSSL )
  • All the docker images we have need to be changed to include the system dependencies
  • The rpm and deb packages need to be changed to reflect the table in issue Build improvements: Dynamic builds #963 regarding dependencies
  • Switch to CircleCI
  • CI needs to have the dynamic dependencies
  • Documentation
    • Change the falco source documentation to reflect the new build dependencies
    • Warn in the falco source documentation about this paradigm change from all static to dynamic

Doc revamping ongoing into falcosecurity/falco-website#115

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #963

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: falco-tester base image is fedora:31 now
build: (most of) dependencies are bundled dynamically (by default)
build: switch to CircleCI

@krisnova
Copy link
Contributor

krisnova commented Dec 11, 2019

Tested locally

[nova@nova build-dynamic]$ make all -j8
[  2%] Built target test-trace-connect_localhost.scap
[  4%] Built target njson
[  4%] Built target b64
[  6%] Built target luajit
[  8%] Built target tbb
[  8%] Built target test-trace-ping_sendto.scap
[ 10%] Built target civetweb
[ 11%] Built target test-trace-open-multiple-files.scap
[ 11%] Built target test-trace-cat_write.scap
[ 11%] Built target test-trace-syscall.scap
[ 11%] Built target test-trace-empty.scap
[ 11%] Built target test-trace-delete_configmap.json
[ 11%] Built target test-trace-create_nginx_pod_unsensitive_mount.json
[ 12%] Built target test-trace-create_pod_kube_public_namespace.json
[ 12%] Built target test-trace-create_nginx_pod_sensitive_mount_2nd_container.json
[ 12%] Built target test-trace-create_nginx_pod_sensitive_mount.json
[ 13%] Built target test-trace-create_nginx_pod_privileged.json
[ 13%] Built target test-trace-create_nginx_service_nonodeport.json
[ 13%] Built target test-trace-create_deployment.json
[ 14%] Built target test-trace-delete_cluster_role_kube_aggregator.json
[ 14%] Built target test-trace-create_cluster_role_pod_exec.json
[ 15%] Built target test-trace-create_serviceaccount.json
[ 15%] Built target test-trace-attach_pod.json
[ 16%] Built target test-trace-anonymous_creates_namespace_foo.json
[ 16%] Built target test-trace-create_cluster_role_write_privileges.json
[ 16%] Built target test-trace-delete_namespace_foo.json
[ 16%] Built target test-trace-delete_clusterrolebinding.json
[ 16%] Built target test-trace-attach_cluster_admin_role.json
[ 16%] Built target test-trace-minikube_creates_namespace_foo.json
[ 16%] Built target test-trace-create_cluster_role_wildcard_verbs.json
[ 17%] Built target test-trace-create_cluster_role_wildcard_resources.json
[ 17%] Built target test-trace-create_configmap.json
[ 17%] Built target test-trace-create_nginx_service_nodeport.json
[ 17%] Built target test-trace-create_configmap_no_sensitive_values.json
[ 18%] Built target test-trace-create_clusterrolebinding.json
[ 18%] Built target test-trace-create_pod_kube_system_namespace.json
[ 18%] Built target test-trace-create_service.json
[ 18%] Built target test-trace-create_serviceaccount_kube_public_namespace.json
[ 18%] Built target test-trace-create_clusterrole.json
[ 18%] Built target test-trace-create_serviceaccount_kube_system_namespace.json
[ 18%] Built target test-trace-delete_clusterrole.json
[ 18%] Built target test-trace-create_nginx_pod_hostnetwork.json
[ 19%] Built target test-trace-delete_deployment.json
[ 19%] Built target test-trace-delete_service.json
[ 19%] Built target test-trace-exec_pod.json
[ 19%] Built target test-trace-create_nginx_pod_nohostnetwork.json
[ 20%] Built target test-trace-create_configmap_sensitive_values.json
[ 20%] Built target test-trace-modify_cluster_role_node_problem_detector.json
[ 21%] Built target test-trace-some-user_creates_namespace_foo.json
[ 22%] Built target test-trace-create_nginx_pod_privileged_2nd_container.json
[ 22%] Built target test-trace-create_nginx_pod_unprivileged.json
[ 22%] Built target test-trace-run_as_user_65534_container.scap
[ 22%] Built target test-trace-run_as_user_1000_sec_ctx_30_container.json
[ 24%] Built target test-trace-write_tmp_test.scap
[ 24%] Built target test-trace-delete_serviceaccount.json
[ 24%] Built target test-trace-run_as_user_30_sec_ctx.json
[ 24%] Built target test-trace-run_as_user_1000_sec_ctx.json
[ 25%] Built target test-trace-run_as_user_1000_container.json
[ 25%] Built target test-trace-run_as_user_0_sec_ctx_1000_container.json
[ 26%] Built target test-trace-host_pid.json
[ 26%] Built target test-trace-privilege_escalation.json
[ 26%] Built target test-trace-run_as_user_0_sec_ctx.json
[ 26%] Built target test-trace-host_ipc.json
[ 26%] Built target test-trace-run_as_group_1000_sec_ctx_30_container.json
[ 26%] Built target test-trace-run_as_user_0_container.json
[ 27%] Built target test-trace-capability_add_sys_time.json
[ 27%] Built target test-trace-supplemental_groups_10_20.json
[ 27%] Built target test-trace-host_network_ports.json
[ 27%] Built target test-trace-create_vanilla_nginx_deployment.json
[ 27%] Built target test-trace-capability_add_sys_nice.json
[ 27%] Built target test-trace-host_network.json
[ 27%] Built target test-trace-run_as_user_30_sec_ctx_1000_container.json
[ 28%] Built target test-trace-run_as_user_0_container.scap
[ 28%] Built target test-trace-run_as_user_1000_sec_ctx_0_container.json
[ 28%] Built target test-trace-mount_etc_using_host_path.json
[ 28%] Built target test-trace-proc_mount_type_default.json
[ 29%] Built target test-trace-fs_group.json
[ 31%] Built target test-trace-run_as_user_30_container.json
[ 31%] Built target test-trace-run_as_group_30_container.json
[ 32%] Built target test-trace-privileged.json
[ 32%] Built target test-trace-run_as_group_1000_container.json
[ 32%] Built target test-trace-privileged.scap
[ 33%] Built target test-trace-read_only_root_fs.json
[ 33%] Built target test-trace-flex_volumes.json
[ 33%] Built target test-trace-run_as_group_30_sec_ctx_1000_container.json
[ 33%] Built target test-trace-run_as_group_1000_sec_ctx.json
[ 33%] Built target test-trace-run_as_group_30_sec_ctx.json
[ 33%] Built target test-trace-proc_mount_type_unmasked.json
[ 34%] Generating docker-entrypoint
[ 34%] Built target local-Dockerfile
[ 35%] Built target docker-local-trace-open-multiple-files.scap
[ 35%] Built target docker-local-trace-ping_sendto.scap
[ 35%] Built target docker-local-trace-empty.scap
[ 35%] Built target docker-local-trace-connect_localhost.scap
[ 35%] Built target docker-local-trace-syscall.scap
[ 36%] Built target docker-local-trace-cat_write.scap
[ 36%] Built target local-docker-entrypoint
[ 36%] Built target docker-local-rule-syscalls.yaml
[ 36%] Built target docker-local-rule-tagged_rules.yaml
[ 36%] Built target docker-local-rule-skip_unknown_evt.yaml
[ 36%] Built target docker-local-rule-rule_order.yaml
[ 36%] Built target docker-local-rule-rule_names_with_spaces.yaml
[ 37%] Built target docker-local-rule-rule_names_with_regex_chars.yaml
[ 38%] Built target docker-local-rule-single_rule.yaml
[ 38%] Built target docker-local-rule-rule_append_false.yaml
[ 38%] Built target docker-local-rule-rule_append_failure.yaml
[ 39%] Built target docker-local-rule-override_rule.yaml
[ 39%] Built target docker-local-rule-override_nested_list.yaml
[ 39%] Built target docker-local-rule-override_macro.yaml
[ 39%] Built target docker-local-rule-override_list.yaml
[ 39%] Built target docker-local-rule-multiple_docs.yaml
[ 40%] Built target docker-local-rule-null_output_field.yaml
[ 40%] Built target docker-local-rule-macro_order.yaml
[ 40%] Built target docker-local-rule-macro_append_false.yaml
[ 40%] Built target docker-local-rule-invalid_missing_list_name.yaml
[ 40%] Built target docker-local-rule-invalid_array_item_not_object.yaml
[ 40%] Built target docker-local-rule-invalid_engine_version_not_number.yaml
[ 41%] Built target docker-local-rule-macro_append_failure.yaml
[ 41%] Built target docker-local-rule-invalid_list_without_items.yaml
[ 41%] Built target docker-local-rule-invalid_overwrite_rule.yaml
[ 42%] Built target docker-local-rule-invalid_condition_not_rule.yaml
[ 42%] Built target docker-local-rule-macro_append.yaml
[ 42%] Built target docker-local-rule-invalid_base_macro.yaml
[ 42%] Built target docker-local-rule-skip_unknown_unspec.yaml
[ 42%] Built target docker-local-rule-invalid_base_rule.yaml
[ 42%] Built target docker-local-rule-invalid_append_rule.yaml
[ 43%] Built target docker-local-rule-invalid_macro_without_condition.yaml
[ 43%] Built target docker-local-rule-endswith.yaml
[ 43%] Built target docker-local-rule-rule_append.yaml
[ 43%] Built target docker-local-rule-empty_rules.yaml
[ 43%] Built target docker-local-rule-double_rule.yaml
[ 43%] Built target docker-local-rule-invalid_append_rule_multiple_docs.yaml
[ 44%] Built target docker-local-rule-detect_connect_using_in.yaml
[ 44%] Built target docker-local-rule-invalid_append_macro.yaml
[ 44%] Built target docker-local-rule-single_rule_enabled_flag.yaml
[ 45%] Built target docker-local-rule-invalid_macro_comple_error.yaml
[ 46%] Built target docker-local-rule-list_sub_bare.yaml
[ 46%] Built target docker-local-rule-append_single_rule.yaml
[ 47%] Built target docker-local-rule-invalid_missing_rule_name.yaml
[ 47%] Built target docker-local-rule-catchall_order.yaml
[ 47%] Built target docker-local-rule-invalid_append_macro_multiple_docs.yaml
[ 48%] Built target docker-local-rule-invalid_rule_output.yaml
[ 48%] Built target docker-local-rule-falco_rules_warnings.yaml
[ 48%] Built target docker-local-rule-invalid_rule_without_output.yaml
[ 48%] Built target docker-local-rule-invalid_not_yaml.yaml
[ 49%] Built target docker-local-rule-list_append.yaml
[ 50%] Built target docker-local-rule-invalid_append_macro_dangling.yaml
[ 51%] Built target docker-local-rule-invalid_missing_macro_name.yaml
[ 51%] Built target docker-local-rule-skip_unknown_prefix.yaml
[ 51%] Built target docker-local-rule-invalid_overwrite_macro.yaml
[ 51%] Built target docker-local-rule-list_sub_front.yaml
[ 51%] Built target docker-local-rule-invalid_not_array.yaml
[ 52%] Built target docker-local-rule-invalid_append_rule_without_condition.yaml
[ 52%] Built target docker-local-rule-invalid_unexpected_object.yaml
[ 52%] Built target docker-local-rule-engine_version_mismatch.yaml
[ 53%] Built target docker-local-rule-invalid_overwrite_rule_multiple_docs.yaml
[ 53%] Built target docker-local-rule-invalid_overwrite_macro_multiple_docs.yaml
[ 53%] Built target docker-local-rule-invalid_yaml_parse_error.yaml
[ 53%] Built target docker-local-rule-skip_unknown_error.yaml
[ 53%] Built target docker-local-rule-list_append_failure.yaml
[ 53%] Built target docker-local-rule-list_append_false.yaml
[ 53%] Built target docker-local-rule-list_order.yaml
[ 54%] Built target docker-local-rule-list_sub_whitespace.yaml
[ 54%] Built target docker-local-rule-list_sub_mid.yaml
[ 54%] Built target docker-local-rule-list_sub_end.yaml
[ 54%] Built target docker-local-rule-list_substring.yaml
[ 58%] Built target scap
[ 60%] Built target catch2
[ 62%] Built target fakeit-external
[ 64%] Built target lpeg
[ 66%] Built target lyaml
[ 67%] Built target scap-open
[ 67%] Built target scap-validatebuffer
[ 92%] Built target sinsp
[ 94%] Built target falco_engine
[ 95%] Built target falco_test
[100%] Built target falco
[100%] Built target driver
[nova@nova build-dynamic]$ uname -a
Linux nova 4.19.88-1-MANJARO #1 SMP PREEMPT Thu Dec 5 11:04:44 UTC 2019 x86_64 GNU/Linux

🇮🇹

@krisnova
Copy link
Contributor

/lgtm

@poiana
Copy link
Contributor

poiana commented Dec 11, 2019

LGTM label has been added.

Git tree hash: 999a9297a6e49a53a6011638ebea51e6cd736f8e

@krisnova
Copy link
Contributor

krisnova commented Dec 11, 2019

Also adding this for documentation

pacman -S zlib jq ncurses yaml-cpp openssl curl c-ares protobuf grpc libyaml

@leodido
Copy link
Member

leodido commented Dec 13, 2019

This is on the right path, but not completed yet.

Anyway, for reference, we should investigate gRPC behaviour when built on CentOS 7. At the moment it builds but gRPC API does not seems to work as intended.

@leogr
Copy link
Member

leogr commented Dec 16, 2019

Hi @fntlnz

Tested locally (archlinux), it worked fine.

$ make all -j16
[  2%] Built target luajit
[  4%] Built target tbb
[  7%] Built target njson
[  8%] Built target b64
[ 10%] Built target civetweb
[ 10%] Built target test-trace-connect_localhost.scap
[ 10%] Built target test-trace-ping_sendto.scap
[ 10%] Built target test-trace-empty.scap
[ 11%] Built target test-trace-open-multiple-files.scap
[ 11%] Built target test-trace-syscall.scap
[ 11%] Built target test-trace-delete_configmap.json
[ 11%] Built target test-trace-cat_write.scap
[ 11%] Built target test-trace-create_nginx_pod_unsensitive_mount.json
[ 12%] Built target test-trace-create_pod_kube_public_namespace.json
[ 12%] Built target test-trace-create_nginx_pod_sensitive_mount.json
[ 12%] Built target test-trace-create_nginx_pod_sensitive_mount_2nd_container.json
[ 14%] Built target test-trace-create_nginx_pod_privileged.json
[ 14%] Built target test-trace-create_serviceaccount.json
[ 14%] Built target test-trace-create_deployment.json
[ 14%] Built target test-trace-create_nginx_service_nonodeport.json
[ 15%] Built target test-trace-delete_cluster_role_kube_aggregator.json
[ 15%] Built target test-trace-create_cluster_role_pod_exec.json
[ 15%] Built target test-trace-attach_pod.json
[ 15%] Built target test-trace-delete_clusterrolebinding.json
[ 15%] Built target test-trace-delete_namespace_foo.json
[ 15%] Built target test-trace-attach_cluster_admin_role.json
[ 15%] Built target test-trace-create_cluster_role_write_privileges.json
[ 16%] Built target test-trace-anonymous_creates_namespace_foo.json
[ 16%] Built target test-trace-create_cluster_role_wildcard_verbs.json
[ 16%] Built target test-trace-create_configmap.json
[ 16%] Built target test-trace-minikube_creates_namespace_foo.json
[ 16%] Built target test-trace-create_nginx_service_nodeport.json
[ 17%] Built target test-trace-create_cluster_role_wildcard_resources.json
[ 17%] Built target test-trace-create_configmap_no_sensitive_values.json
[ 18%] Built target test-trace-create_clusterrolebinding.json
[ 18%] Built target test-trace-create_pod_kube_system_namespace.json
[ 18%] Built target test-trace-create_serviceaccount_kube_public_namespace.json
[ 18%] Built target test-trace-create_service.json
[ 18%] Built target test-trace-create_clusterrole.json
[ 18%] Built target test-trace-create_serviceaccount_kube_system_namespace.json
[ 18%] Built target test-trace-delete_clusterrole.json
[ 19%] Built target test-trace-delete_deployment.json
[ 19%] Built target test-trace-create_nginx_pod_hostnetwork.json
[ 20%] Built target test-trace-create_configmap_sensitive_values.json
[ 20%] Built target test-trace-delete_service.json
[ 20%] Built target test-trace-exec_pod.json
[ 20%] Built target test-trace-create_nginx_pod_nohostnetwork.json
[ 20%] Built target test-trace-create_nginx_pod_privileged_2nd_container.json
[ 21%] Built target test-trace-create_nginx_pod_unprivileged.json
[ 22%] Built target test-trace-some-user_creates_namespace_foo.json
[ 23%] Built target test-trace-write_tmp_test.scap
[ 24%] Built target test-trace-modify_cluster_role_node_problem_detector.json
[ 24%] Built target test-trace-delete_serviceaccount.json
[ 24%] Built target test-trace-run_as_user_1000_sec_ctx_30_container.json
[ 24%] Built target test-trace-run_as_user_65534_container.scap
[ 24%] Built target test-trace-run_as_user_30_sec_ctx.json
[ 24%] Built target test-trace-run_as_user_1000_sec_ctx.json
[ 24%] Built target test-trace-run_as_user_0_sec_ctx_1000_container.json
[ 24%] Built target test-trace-run_as_user_0_sec_ctx.json
[ 25%] Built target test-trace-run_as_user_1000_container.json
[ 25%] Built target test-trace-privilege_escalation.json
[ 25%] Built target test-trace-host_ipc.json
[ 25%] Built target test-trace-run_as_group_1000_sec_ctx_30_container.json
[ 26%] Built target test-trace-host_pid.json
[ 26%] Built target test-trace-run_as_user_0_container.json
[ 27%] Built target test-trace-capability_add_sys_time.json
[ 27%] Built target test-trace-supplemental_groups_10_20.json
[ 27%] Built target test-trace-host_network_ports.json
[ 27%] Built target test-trace-create_vanilla_nginx_deployment.json
[ 27%] Built target test-trace-capability_add_sys_nice.json
[ 27%] Built target test-trace-host_network.json
[ 27%] Built target test-trace-run_as_user_1000_sec_ctx_0_container.json
[ 27%] Built target test-trace-run_as_user_30_sec_ctx_1000_container.json
[ 28%] Built target test-trace-run_as_user_0_container.scap
[ 28%] Built target test-trace-mount_etc_using_host_path.json
[ 29%] Built target test-trace-run_as_user_30_container.json
[ 29%] Built target test-trace-proc_mount_type_default.json
[ 30%] Built target test-trace-fs_group.json
[ 31%] Built target test-trace-privileged.json
[ 32%] Built target test-trace-run_as_group_30_container.json
[ 32%] Built target test-trace-run_as_group_1000_container.json
[ 33%] Built target test-trace-read_only_root_fs.json
[ 33%] Built target test-trace-privileged.scap
[ 33%] Built target test-trace-run_as_group_1000_sec_ctx.json
[ 33%] Built target test-trace-flex_volumes.json
[ 33%] Built target test-trace-run_as_group_30_sec_ctx.json
[ 33%] Built target test-trace-proc_mount_type_unmasked.json
[ 33%] Built target test-trace-run_as_group_30_sec_ctx_1000_container.json
[ 34%] Generating docker-entrypoint
[ 34%] Built target local-Dockerfile
[ 35%] Built target docker-local-trace-open-multiple-files.scap
[ 35%] Built target docker-local-trace-connect_localhost.scap
[ 35%] Built target docker-local-trace-empty.scap
[ 35%] Built target docker-local-trace-ping_sendto.scap
[ 35%] Built target docker-local-rule-tagged_rules.yaml
[ 35%] Built target docker-local-trace-syscall.scap
[ 36%] Built target docker-local-trace-cat_write.scap
[ 36%] Built target local-docker-entrypoint
[ 36%] Built target docker-local-rule-rule_order.yaml
[ 36%] Built target docker-local-rule-syscalls.yaml
[ 37%] Built target docker-local-rule-rule_names_with_regex_chars.yaml
[ 37%] Built target docker-local-rule-skip_unknown_evt.yaml
[ 38%] Built target docker-local-rule-single_rule.yaml
[ 38%] Built target docker-local-rule-override_nested_list.yaml
[ 39%] Built target docker-local-rule-override_rule.yaml
[ 39%] Built target docker-local-rule-rule_names_with_spaces.yaml
[ 39%] Built target docker-local-rule-override_macro.yaml
[ 39%] Built target docker-local-rule-rule_append_false.yaml
[ 39%] Built target docker-local-rule-rule_append_failure.yaml
[ 39%] Built target docker-local-rule-override_list.yaml
[ 39%] Built target docker-local-rule-multiple_docs.yaml
[ 40%] Built target docker-local-rule-null_output_field.yaml
[ 40%] Built target docker-local-rule-macro_append_false.yaml
[ 40%] Built target docker-local-rule-macro_order.yaml
[ 40%] Built target docker-local-rule-invalid_engine_version_not_number.yaml
[ 40%] Built target docker-local-rule-invalid_missing_list_name.yaml
[ 40%] Built target docker-local-rule-invalid_list_without_items.yaml
[ 41%] Built target docker-local-rule-macro_append_failure.yaml
[ 41%] Built target docker-local-rule-invalid_array_item_not_object.yaml
[ 41%] Built target docker-local-rule-invalid_overwrite_rule.yaml
[ 41%] Built target docker-local-rule-macro_append.yaml
[ 42%] Built target docker-local-rule-invalid_condition_not_rule.yaml
[ 42%] Built target docker-local-rule-skip_unknown_unspec.yaml
[ 42%] Built target docker-local-rule-invalid_base_rule.yaml
[ 43%] Built target docker-local-rule-endswith.yaml
[ 43%] Built target docker-local-rule-invalid_base_macro.yaml
[ 43%] Built target docker-local-rule-invalid_append_rule.yaml
[ 43%] Built target docker-local-rule-invalid_macro_without_condition.yaml
[ 43%] Built target docker-local-rule-rule_append.yaml
[ 43%] Built target docker-local-rule-empty_rules.yaml
[ 43%] Built target docker-local-rule-single_rule_enabled_flag.yaml
[ 43%] Built target docker-local-rule-invalid_append_rule_multiple_docs.yaml
[ 43%] Built target docker-local-rule-double_rule.yaml
[ 43%] Built target docker-local-rule-invalid_append_macro.yaml
[ 44%] Built target docker-local-rule-detect_connect_using_in.yaml
[ 45%] Built target docker-local-rule-invalid_macro_comple_error.yaml
[ 46%] Built target docker-local-rule-list_sub_bare.yaml
[ 47%] Built target docker-local-rule-invalid_missing_rule_name.yaml
[ 47%] Built target docker-local-rule-append_single_rule.yaml
[ 47%] Built target docker-local-rule-catchall_order.yaml
[ 48%] Built target docker-local-rule-invalid_rule_output.yaml
[ 48%] Built target docker-local-rule-falco_rules_warnings.yaml
[ 48%] Built target docker-local-rule-invalid_not_yaml.yaml
[ 48%] Built target docker-local-rule-invalid_append_macro_multiple_docs.yaml
[ 49%] Built target docker-local-rule-skip_unknown_prefix.yaml
[ 49%] Built target docker-local-rule-invalid_rule_without_output.yaml
[ 50%] Built target docker-local-rule-list_append.yaml
[ 50%] Built target docker-local-rule-list_sub_front.yaml
[ 51%] Built target docker-local-rule-invalid_append_macro_dangling.yaml
[ 51%] Built target docker-local-rule-invalid_missing_macro_name.yaml
[ 51%] Built target docker-local-rule-invalid_not_array.yaml
[ 52%] Built target docker-local-rule-invalid_append_rule_without_condition.yaml
[ 52%] Built target docker-local-rule-invalid_overwrite_macro.yaml
[ 52%] Built target docker-local-rule-engine_version_mismatch.yaml
[ 52%] Built target docker-local-rule-invalid_overwrite_rule_multiple_docs.yaml
[ 52%] Built target docker-local-rule-invalid_unexpected_object.yaml
[ 53%] Built target docker-local-rule-invalid_overwrite_macro_multiple_docs.yaml
[ 53%] Built target docker-local-rule-invalid_yaml_parse_error.yaml
[ 53%] Built target docker-local-rule-list_append_failure.yaml
[ 53%] Built target docker-local-rule-skip_unknown_error.yaml
[ 53%] Built target docker-local-rule-list_append_false.yaml
[ 53%] Built target docker-local-rule-list_order.yaml
[ 54%] Built target docker-local-rule-list_sub_whitespace.yaml
[ 54%] Built target docker-local-rule-list_sub_end.yaml
[ 54%] Built target docker-local-rule-list_sub_mid.yaml
[ 54%] Built target docker-local-rule-list_substring.yaml
[ 58%] Built target scap
[ 60%] Built target catch2
[ 62%] Built target fakeit-external
[ 64%] Built target lpeg
[ 66%] Built target lyaml
[ 67%] Built target scap-open
[ 67%] Built target scap-validatebuffer
[ 92%] Built target sinsp
[ 94%] Built target falco_engine
[ 95%] Built target falco_test
[100%] Built target falco
[100%] Built target driver
$ uname -a 
Linux pr 5.4.2-arch1-1 #1 SMP PREEMPT Thu, 05 Dec 2019 12:29:40 +0000 x86_64 GNU/Linux

Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
fntlnz and others added 5 commits January 17, 2020 14:48
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Contributor Author

fntlnz commented Jan 17, 2020

/meow tests finally passed!!!!!

@poiana
Copy link
Contributor

poiana commented Jan 17, 2020

@fntlnz: cat image

In response to this:

/meow tests finally passed!!!!!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leodido
Copy link
Member

leodido commented Jan 17, 2020

greeeeeny 💚

/honk

@poiana
Copy link
Contributor

poiana commented Jan 17, 2020

@leodido:
goose image

In response to this:

greeeeeny 💚

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-Authored-By: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member

leodido commented Jan 17, 2020

Ok, release notes ready!

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥇

@poiana
Copy link
Contributor

poiana commented Jan 17, 2020

LGTM label has been added.

Git tree hash: 11dca9c38c4d180225fa51337264ebfa2ecca9e3

@poiana
Copy link
Contributor

poiana commented Jan 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kris-nova, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido changed the title wip: Dynamic builds (mostly) Dynamic builds (mostly) Jan 17, 2020
@leodido leodido merged commit c8a89f4 into dev Jan 17, 2020
@poiana poiana deleted the feat/dynamic-builds branch January 17, 2020 18:09
@fntlnz fntlnz added this to the 0.19.0 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build improvements: Dynamic builds
6 participants