Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update k8s registry domain #232

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 17, 2023

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

  • update k8s registry domain

part of kubernetes/k8s.io#4780

/assign @leogr

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@cpanato
Copy link
Member Author

cpanato commented Feb 20, 2023

/assign @jasondellaluce

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the rules can also run on environments not up-to-date, I'd keep both domains (ie k8s.grc.io and registry.k8s.io).

@LucaGuerra @darryk10 @loresuso wdyt?

@darryk10
Copy link
Contributor

I agree on keeping them both. Some k8s version will still remain in the old domain so it makes sense to whitelist them both. In the future we would consider removing the old one.

@cpanato
Copy link
Member Author

cpanato commented Feb 20, 2023

sound good and thanks for the feedback, i will update those and add a comment
@leogr @darryk10

Signed-off-by: cpanato <ctadeu@gmail.com>
@@ -186,6 +186,7 @@
tags: [k8s]

# These container images are allowed to run with hostnetwork=true
# TODO: Remove k8s.gcr.io reference after 01/Dec/2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leogr @darryk10 added this date to we remove the k8s reference after December
the k8s registry will be frozen on 3rd of April 2023 (https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/) so we give some extra time for people to update the clusters.
wdyt?

@cpanato cpanato requested review from leogr and removed request for mstemm February 21, 2023 08:23
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/hold for a second opinion cc @falcosecurity/rules-maintainers @falcosecurity/plugins-maintainers

@poiana
Copy link
Contributor

poiana commented Feb 22, 2023

LGTM label has been added.

Git tree hash: 890f19f92c5002b381bcc06a73be8083ee408446

@poiana
Copy link
Contributor

poiana commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LucaGuerra
Copy link
Contributor

/unhold

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants