-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update k8s registry domain #232
Conversation
/assign @jasondellaluce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the rules can also run on environments not up-to-date, I'd keep both domains (ie k8s.grc.io
and registry.k8s.io
).
@LucaGuerra @darryk10 @loresuso wdyt?
I agree on keeping them both. Some k8s version will still remain in the old domain so it makes sense to whitelist them both. In the future we would consider removing the old one. |
Signed-off-by: cpanato <ctadeu@gmail.com>
@@ -186,6 +186,7 @@ | |||
tags: [k8s] | |||
|
|||
# These container images are allowed to run with hostnetwork=true | |||
# TODO: Remove k8s.gcr.io reference after 01/Dec/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leogr @darryk10 added this date to we remove the k8s reference after December
the k8s registry will be frozen on 3rd of April 2023 (https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/) so we give some extra time for people to update the clusters.
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold for a second opinion cc @falcosecurity/rules-maintainers @falcosecurity/plugins-maintainers
LGTM label has been added. Git tree hash: 890f19f92c5002b381bcc06a73be8083ee408446
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold LGTM, thanks! |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
part of kubernetes/k8s.io#4780
/assign @leogr
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: