Automatic drivers cleanup #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
force-pushed
the
feat/drivers-cleanup
branch
from
3bcf912 to
0b01fb4
Compare
leodido
commented
Sep 2, 2020
driverkit/utils/cleanup
Outdated
| printf "%s\t%s\n" "$i" "${all[$i]}" | ||
| if [[ ! " ${keep[*]}" =~ ${all[$i]} ]]; then | ||
| printf " \tremoving..." | ||
| JFROG_CLI_LOG_LEVEL=DEBUG jfrog bt vd --user "${user}" --key "${pass}" "falcosecurity/driver/kernel-module/${all[$i]}" --quiet |
There was a problem hiding this comment.
Here we could download (or directly move the driver) to S3 for archivation as per proposal in falcosecurity/falco#1375.
Waiting for feedback.
Should we block this task until we have S3?
Should we implement the archivation step in a second phase?
|
Until I do some other checks /hold |
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
fntlnz
approved these changes
Sep 7, 2020
|
LGTM label has been added. Git tree hash: 2837646881d67da4b4bfd82e8d69066ca8062f62
|
leogr
approved these changes
Sep 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
driverkit/utilsthat (given the bintray secret plus a list of driver versions to keep) queries bintray API to obtain all the existing driver versions and filter them out by keeping only the two driver versions specified as inputdriverkit/configdirectorydrivers/cleanup) that puts all the pieces together and runs on every merge into master