Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Support single-source sync #80

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jannden
Copy link
Contributor

@jannden jannden commented Nov 4, 2024

Closes: #81

This fixes tests for: #79

As per this comment.

@jannden
Copy link
Contributor Author

jannden commented Nov 4, 2024

As mentioned in the original PR in this comment, we first need to clarify how to approach the clash between LDAP and CSV sync. Then a small adjustment to the test_e2e_full_sync is expected and this should be ready to go.

@jannden jannden self-assigned this Nov 4, 2024
@jannden jannden marked this pull request as ready for review November 4, 2024 10:39
@jannden jannden requested a review from a team as a code owner November 4, 2024 10:39
Copy link
Contributor

@tlater-famedly tlater-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like this!

@@ -19,6 +19,7 @@ feature_flags:
# - deactivate_only # Only deactivate users, do not create or update them. Keep in mind LDAP is cached and all the changes made on LDAP will be written to the cache as if they where applied. Therefore, only the deactivation changes will be applied to Zitadel but **all the other changes will be lost**.

# Configuration for the sources to sync from.
# IMPORTANT: Only one source can be present at a time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sample config should be split in three for this, don't want to document something that can never work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's split the sample as part of the documentation commit on the feature branch.

@jannden jannden merged commit a4ec83e into tlater/remove-cache Nov 4, 2024
1 check passed
@jannden jannden deleted the jannden/remove-cache-tests branch November 4, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants