avoid ReferenceError when using fallback for ES6 Map #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Mar 27, 2022
Reviewed package diff via <https://diff.intrinsic.com/fuzzysort/1.1.4/1.2.1>. The main reason for updating is to bring in my upstream fix (ref farzher/fuzzysort#72, and ref farzher/fuzzysort#93) to not depend on ES6 Map being globally defined. This unblocks the next commit, which is removing the hack for loading es6-map.js in an unusual way. That unusual way actually caused both our own use in test.js and fuzzysort.js to *not* see the native Map anymore in supporting environents, which I'll fix as well. Also, since this is a dependency that we bundle as part of the distribution, pin its version exactly, as we do with `kleur`.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Mar 27, 2022
Reviewed package diff via <https://diff.intrinsic.com/fuzzysort/1.1.4/1.2.1>. The main reason for updating is to bring in my upstream fix (ref farzher/fuzzysort#72, and ref farzher/fuzzysort#93) to not depend on ES6 Map being globally defined. This unblocks the next commit, which is removing the hack for loading es6-map.js in an unusual way. That unusual way actually caused both our own use in test.js and fuzzysort.js to *not* see the native Map anymore in supporting environents, which I'll fix as well. Also, since this is a dependency that we bundle as part of the distribution, pin its version exactly, as we do with `kleur`.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Mar 28, 2022
Reviewed package diff via <https://diff.intrinsic.com/fuzzysort/1.1.4/1.2.1>. The main reason for updating is to bring in my upstream fix (ref farzher/fuzzysort#72, and ref farzher/fuzzysort#93) to not depend on ES6 Map being globally defined. This unblocks the next commit, which is removing the hack for loading es6-map.js in an unusual way. That unusual way actually caused both our own use in test.js and fuzzysort.js to *not* see the native Map anymore in supporting environents, which I'll fix as well. Also, since this is a dependency that we bundle as part of the distribution, pin its version exactly, as we do with `kleur`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #71.
Ref #72.