feat: make visitor early-stoppable #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
andylokandy
reviewed
Oct 26, 2025
| /// A visitor that can be used to traverse a data structure. | ||
| pub trait Visitor { | ||
| /// The type that can be used to break traversal early. | ||
| type Break; |
There was a problem hiding this comment.
Suggested change
| type Break; | |
| type Break = (); |
maybe give it a default?
Contributor
Author
There was a problem hiding this comment.
This is not yet stabilized - https://rust-lang.github.io/rfcs/2532-associated-type-defaults.html
andylokandy
reviewed
Oct 26, 2025
Comment on lines
+25
to
+29
| pub struct FnVisitor<T, B, F1, F2> { | ||
| enter: F1, | ||
| leave: F2, | ||
| m: PhantomData<T>, | ||
| marker_type: PhantomData<T>, | ||
| marker_break: PhantomData<B>, |
There was a problem hiding this comment.
PhantomData can be eliminated once we move the F1 F2 bound onto struct.
Contributor
Author
There was a problem hiding this comment.
Maybe you can make a follow-up? I suppose then we need both FnVisitor and FnMutVisitor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2