Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use node's URL module #83

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Do not use node's URL module #83

merged 1 commit into from
Jun 5, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Jun 4, 2024 •
edited
Loading

fixes #82

@gurgunday gurgunday requested a review from a team June 4, 2024 17:57
@gurgunday gurgunday changed the title fix #82 Do not use node's URL module Jun 4, 2024
@gurgunday gurgunday requested a review from mcollina June 4, 2024 19:31
@gurgunday gurgunday mentioned this pull request Jun 4, 2024
Merged
@gurgunday gurgunday requested review from Uzlopak and zekth June 4, 2024 22:07
@gurgunday gurgunday merged commit ea8762e into fastify:main Jun 5, 2024
26 checks passed
@gurgunday gurgunday deleted the fix branch June 5, 2024 08:11
@gurgunday gurgunday mentioned this pull request Jun 7, 2024
Open
2 tasks
@X-oss-byte X-oss-byte mentioned this pull request Jul 5, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@zekth zekth Awaiting requested review from zekth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change require "url" to "node:url" did make it incompatible with usage inside browser / web
2 participants
@gurgunday @Fdawgs