fix for passing Buffer object as secretOrPublicKey #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemremengu
reviewed
Mar 13, 2019
|
Added support for signing tokens with a Buffer object and relevant tests. Please let me know if that works. |
mcollina
reviewed
Mar 13, 2019
jwt.js
Outdated
| @@ -53,15 +53,17 @@ function fastifyJwt (fastify, options, next) { | |||
| signOptions && | |||
| signOptions.algorithm && | |||
| signOptions.algorithm.includes('RS') && | |||
| typeof secret === 'string' | |||
| (typeof secret === 'string' || | |||
| Buffer.isBuffer(secret)) | |||
There was a problem hiding this comment.
Suggested change
| Buffer.isBuffer(secret)) | |
| secret instanceof Buffer) |
Co-Authored-By: lwojcik <1711174+lwojcik@users.noreply.github.com>
|
Buffer enables byte array to be used as a secret, including base64 encoding. On the readme of node-jsonwebtoken, search for "base64". This is an essential feature of Please review |
|
@mcollina I will patch this in if you are good to go |
|
go for it!
Il giorno ven 15 mar 2019 alle 08:14 Cemre Mengu <notifications@github.com>
ha scritto:
… @mcollina <https://github.com/mcollina> I will patch this in if you are
good to go
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL4-Ghks6LlOrXlZNfOZ3rfYHJTqXaks5vW0hugaJpZM4bsFOt>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While moving one of my projects from Express to Fastify I noticed
fastify-jwtdoesn't handleBufferobjects passed asoptions.secretin a correct way, causing JWT verification attempts to fail. I'm working with a Twitch.tv extension and it expects me to verify tokens with Buffer objects. I was able to do it withjsonwebtokenandBuffer.from(...), butfastify-jwtthrowsError('missing private key and/or public key').I made a quick fix that causes the project to pass
Bufferobjects directly tosecretOrPublicKeyvariable, making it possible to successfuly verify JWTs in cases like the one I described above.Alternatively,!Buffer.isBuffer(secret)can also be used as a condition.