Skip to content

Commit

Permalink
Merge next into master (#199)
Browse files Browse the repository at this point in the history
* Update for Fastify v5 (#192)

* Update for fastify 5

* removed coverage disable

* replaced istambul with c8

* wrapped code in c8

* fix

---------

Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>

* Update for Fastify v5 (#192)

* Update for fastify 5

* removed coverage disable

* replaced istambul with c8

* wrapped code in c8

* fix

---------

Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>

* update fastify deps

---------

Co-authored-by: Cristian Barlutiu <cristian.barlutiu@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
  • Loading branch information
3 people authored Jul 9, 2024
1 parent 255ca57 commit c2fc0aa
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:

jobs:
test:
uses: fastify/workflows/.github/workflows/plugins-ci-redis.yml@v3
uses: fastify/workflows/.github/workflows/plugins-ci-redis.yml@v4.1.0
with:
lint: true
license-check: true
Expand Down
7 changes: 0 additions & 7 deletions .taprc
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@
ts: false
jsx: false
flow: false
jobs: 1
coverage: true
check-coverage: true

files:
- test/**/*.test.js
6 changes: 4 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function fastifyRedis (fastify, options, next) {
}

// Testing this make the process crash on latest TAP :(
/* istanbul ignore next */
/* c8 ignore start */
const onEnd = function (err) {
client
.off('ready', onReady)
Expand All @@ -77,6 +77,7 @@ function fastifyRedis (fastify, options, next) {

next(err)
}
/* c8 ignore stop */

const onReady = function () {
client
Expand All @@ -88,7 +89,7 @@ function fastifyRedis (fastify, options, next) {
}

// Testing this make the process crash on latest TAP :(
/* istanbul ignore next */
/* c8 ignore start */
const onError = function (err) {
if (err.code === 'ENOTFOUND') {
onEnd(err)
Expand All @@ -105,6 +106,7 @@ function fastifyRedis (fastify, options, next) {
onEnd(err)
}
}
/* c8 ignore stop */

// ioredis provides it in a .status property
if (client.status === 'ready') {
Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,18 @@
},
"homepage": "https://github.com/fastify/fastify-redis#readme",
"devDependencies": {
"@fastify/pre-commit": "^2.0.2",
"@types/node": "^20.1.0",
"fastify": "^4.0.0-rc.2",
"@fastify/pre-commit": "^2.1.0",
"@types/node": "^20.11.30",
"fastify": "^5.0.0-alpha.3",
"proxyquire": "^2.1.3",
"standard": "^17.0.0",
"tap": "^16.0.0",
"standard": "^17.1.0",
"tap": "^18.7.1",
"tsd": "^0.31.0",
"why-is-node-running": "^2.2.2"
},
"dependencies": {
"fastify-plugin": "^4.0.0",
"ioredis": "^5.0.0"
"fastify-plugin": "^5.0.0-pre.fv5.1",
"ioredis": "^5.3.2"
},
"publishConfig": {
"access": "public"
Expand Down

0 comments on commit c2fc0aa

Please sign in to comment.