last update time at /benchmarks page

[Eomm]

The https://fastify.dev/benchmarks page lacks the last date we updated the data.
It would be cool to add it

[Davidthecode]

hey @Eomm i could work on this. ill need information on the date and where you want to add it

[Eomm]

Here is the script we use to download the data:
https://github.com/fastify/website/blob/main/scripts/download-benchmarks.js

I think the date is there

where you want to add it

i'm not good at design, I would put it at the bottom of the current table, but happy to see your ideas too

[simoneb]

folks anybody had a chance to review the PR linked to this issue?

[Gesma94]

I took a look at the PR. I'm not too sure if what I have found is the real problem, but..

In job build-and-upload we upload the artifact using actions/upload-pages-artifact@v3, which then uses actions/upload-artifact@v4: https://github.com/fastify/website/actions/runs/8246279348/job/23235146867?pr=198#step:12:1

But then, in job deploy-to-staging we are using alehechka/download-tartifact@v2, which then uses actions/download-artifact@v3: https://github.com/fastify/website/actions/runs/8246279348/job/23235339407?pr=198#step:3:1

By looking at the pages of actions/download-artifact and actions/upload-artifact, compatibility between version is not always granted. Moreover, different comment on SO states that we should really use the same version between upload and download:

• https://stackoverflow.com/a/78239268/6070423
• https://stackoverflow.com/a/78108523/6070423

The "biggest" problem is that alehechka/download-tartifact@v2 is not maintained by us, thus we should "extract" all of the steps and then use the actions/download-artifact@v4.

@simoneb if you can it is worth it, I can try to do that, and if then our pipelines works, raise a PR for alehechka/download-tartifact in order to use actions/download-artifact@v4.

[simoneb]

@Gesma94 thanks for looking into it. Why don't we ask the maintainer to upgrade to the latest version of the native action instead?

[Gesma94]

I would do that, but since I'm not sure the problem is really the one I mentioned, a new release of alehechka/download-tartifact might not fix the problem. Also, we would need to wait for him to make a new release.

My idea was:

1. I change the pipeline using the native actions instead of alehechka/download-tartifact
2. If step (1) fixes the pipeline, open a PR to bump dependencies in alehechka/download-tartifact
3. Open a new issue telling "when a new version of alehechka/download-tartifact comes out, use that"

Eventually, when and if a new release will come out, we will go back to using it.

What do you think?

[Eomm]

I think @Gesma94 found the issue and it is written in the release https://github.com/actions/download-artifact/releases/tag/v4.0.0 :

Uploads and downloads must use the same major actions versions

I wrote this maintenance PR #209

Here it has run successfully: #211

[Gesma94]

I've created issue #213 in case we want to go back using download-tartifact once a new version will be released. In the meanwhile, I would close this issue since @Eomm successfully fixed the issue and we have a successful run.