Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when delete entity request goes wrong #61

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fix error when delete entity request goes wrong #61

merged 1 commit into from
Jan 15, 2021

Conversation

martinjaimem
Copy link
Contributor

Closes #60

bronzdoc
bronzdoc approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@bronzdoc bronzdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @martinjaimem, thank you!

@bronzdoc
Copy link
Contributor

@martinjaimem can you add a test for this?

@etagwerker etagwerker merged commit 4b2bb99 into fastruby:main Jan 15, 2021
@etagwerker
Copy link
Member

@martinjaimem @bronzdoc I went ahead and added a test over here: b211ff3#diff-e9c4f6f93bc0a6899ca789ad7f1002c294d9850ccc2cd8c8cd9f4831c364d145R115

@etagwerker
Copy link
Member

@martinjaimem @bronzdoc Just released this fix in v0.5.1: https://rubygems.org/gems/harvesting/versions/0.5.1 -- Thanks! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bronzdoc bronzdoc bronzdoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeEntry: Delete with a 404 code will raise NoMethodError
3 participants
@martinjaimem @bronzdoc @etagwerker