-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GoAddTags: allow modifying existing comments #984
Labels
Comments
Closed
fatih
added a commit
that referenced
this issue
Feb 13, 2017
* Use new `gomodifytags` tool to manipulate and modify tags * Adds new `:GoRenameTags` * `:GoAddTags` is able to add options * `:GoRemoveTags` is able to remove options Usage: Following command add multiple tags. Does not modify if the key already exist. If `,optionaname` is given, it adds the given option to that key. If called without arguments, it adds by default tags with `json` key. ``` :GoAddTags :GoAddTags json :GoAddTags json,omitempty :GoAddTags json hcl bson :GoAddTags json,omitempty hcl bson ``` Following command removes multiple tags and options. If `,optionname` is given, it removes the option belonging to that key instead of removing the key. If called without arguments, it removes all tags belonging to a struct. ``` :GoRemoveTags :GoRemoveTags json :GoRemoveTags json,omitempty :GoRemoveTags json hcl bson :GoRemoveTags json,omitempty hcl bson ``` Fixes following issues: #984 #985 #990 #1064 #1091
fatih
added a commit
that referenced
this issue
Feb 13, 2017
* Use new `gomodifytags` tool to manipulate and modify tags * Adds new `:GoRenameTags` * `:GoAddTags` is able to add options * `:GoRemoveTags` is able to remove options Usage: Following command add multiple tags. Does not modify if the key already exist. If `,optionaname` is given, it adds the given option to that key. If called without arguments, it adds by default tags with `json` key. ``` :GoAddTags :GoAddTags json :GoAddTags json,omitempty :GoAddTags json hcl bson :GoAddTags json,omitempty hcl bson ``` Following command removes multiple tags and options. If `,optionname` is given, it removes the option belonging to that key instead of removing the key. If called without arguments, it removes all tags belonging to a struct. ``` :GoRemoveTags :GoRemoveTags json :GoRemoveTags json,omitempty :GoRemoveTags json hcl bson :GoRemoveTags json,omitempty hcl bson ``` Fixes following issues: #984 #985 #990 #1064 #1091
fatih
added a commit
that referenced
this issue
Feb 13, 2017
* Use new `gomodifytags` tool to manipulate and modify tags * `:GoAddTags` is able to add tags and options * `:GoRemoveTags` is able to remove tags and options Usage: Following command add multiple tags. Does not modify if the key already exist. If `,optionaname` is given, it adds the given option to that key. If called without arguments, it adds by default tags with `json` key. ``` :GoAddTags :GoAddTags json :GoAddTags json,omitempty :GoAddTags json hcl bson :GoAddTags json,omitempty hcl bson ``` Following command removes multiple tags and options. If `,optionname` is given, it removes the option belonging to that key instead of removing the key. If called without arguments, it removes all tags belonging to a struct. ``` :GoRemoveTags :GoRemoveTags json :GoRemoveTags json,omitempty :GoRemoveTags json hcl bson :GoRemoveTags json,omitempty hcl bson ``` Fixes following issues: #984 #985 #990 #1064 #1091
fatih
added a commit
that referenced
this issue
Feb 13, 2017
* Use new `gomodifytags` tool to manipulate and modify tags * `:GoAddTags` is able to add tags and options * `:GoRemoveTags` is able to remove tags and options Usage: Following command add multiple tags. Does not modify if the key already exist. If `,optionaname` is given, it adds the given option to that key. If called without arguments, it adds by default tags with `json` key. ``` :GoAddTags :GoAddTags json :GoAddTags json,omitempty :GoAddTags json hcl bson :GoAddTags json,omitempty hcl bson ``` Following command removes multiple tags and options. If `,optionname` is given, it removes the option belonging to that key instead of removing the key. If called without arguments, it removes all tags belonging to a struct. ``` :GoRemoveTags :GoRemoveTags json :GoRemoveTags json,omitempty :GoRemoveTags json hcl bson :GoRemoveTags json,omitempty hcl bson ``` Fixes following issues: #984 #985 #990 #1064 #1091
Fixed with #1204 please, feel free to test and reopen if it's not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all thank you for the
GoAddTags
feature, it is really great. Sometimes I do want to add a tag to a struct field which already has an existing tag set which leads to this output:which does not compile. It would be great if
GoAddTags
would keep already existing tags but also add the new tag.The text was updated successfully, but these errors were encountered: