Remove old goimports -srcdir workaround and fix :GoFmtAutoSaveToggle #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That flag isn't safe to remove; it's essential to how formatting with goimports works. The |
This check was added two years ago in #735. I think it's safe to remove now? It doesn't really do any harm, but does simplify things a bit. Also happened to notice that `:GoFmtAutoSaveToggle` was broken: Error detected while processing function go#fmt#ToggleFmtAutoSave: line 7: E118: Too many arguments for function: go#config#FmtAutosave So fix that as well.
|
Looks like the |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was added two years ago in #735. I think it's safe to remove
now? It doesn't really do any harm, but does simplify things a bit.
Also happened to notice that
:GoFmtAutoSaveTogglewas broken:Error detected while processing function go#fmt#ToggleFmtAutoSave:
line 7:
E118: Too many arguments for function: go#config#FmtAutosave
So fix that as well.