Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-onboarding-step): focus trap disable scroll #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

J-Michalek
Copy link

@J-Michalek J-Michalek commented Nov 7, 2024

I have been running into issues where sometimes the focus trap would instantly scroll to an element.

To my understanding there is never a case where we would like to do this because the scrollToStep options should take care of this at all times.

  • scrollToStep.enabled === false - We never want to scroll.
  • scrollToStep.enabled === true && scrollToStep.options.behavior === "instant" - We scroll instantly anyway, no need to scroll during the focus.
  • scrollToStep.enabled === true && scrollToStep.options.behavior === "smooth" - We scroll smoothly, we don't want the instant scroll triggered by the focus trap to interfere

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for beamish-dango-bc9c2d canceled.

Name Link
🔨 Latest commit 4379c28
🔍 Latest deploy log https://app.netlify.com/sites/beamish-dango-bc9c2d/deploys/672cab191c3525000856cf3b

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for eloquent-lamport-f2ffa1 canceled.

Name Link
🔨 Latest commit 4379c28
🔍 Latest deploy log https://app.netlify.com/sites/eloquent-lamport-f2ffa1/deploys/672cab193643f50008337c3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant