Propose an alternative way to solve regression #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new type of descendant token which accepts element itself. This looks more elegant and efficient than the previous commit which added complexity to the code and parameters. This is only used while querying an array of elements.
Could throw an error if a query is just ":scope" for example, because of `t[1]` while tokens array contains only one element.
fb55
added a commit
that referenced
this pull request
Nov 24, 2015
Propose an alternative way to solve regression
|
@Delgan Haha, nice improvement :) I would call the new token type |
|
@fb55 Oops, sorry about that, it is fixed now, thank you. |
fb55
added a commit
that referenced
this pull request
Oct 21, 2018
Propose an alternative way to solve regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of my previous pull request.
I am glad I could help you.
But I said my changes looked ugly, so I tried to improve it.
This commit looks more elegant and efficient than the previous one which added complexity to the code and parameters while trying to make a special descendant selector "flexible".
I think the best is simply to add a new "flexible descendant" selector, so I created a new type of descendant token which accepts element itself. Then, I replace classic descendant within the rule if conditions are fulfilled.