fix: allow underscores in domain names

Apparently, underscores are not allowed in hostnames, but allowed in domain names.
fczbkk · Apr 28, 2018 · 94c33ca · 94c33ca
1 parent 8a831e2
commit 94c33ca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/host.js b/src/host.js
@@ -34,7 +34,7 @@ export default class extends UrlPart {
       // escape all dots
       {substring: '.', replacement: '\\.'},
       // replace asterisks with pattern
-      {substring: '*', replacement: '[a-z0-9-.]+'}
+      {substring: '*', replacement: '[a-z0-9-_.]+'}
     ];
   }
 

diff --git a/test/host.spec.js b/test/host.spec.js
@@ -52,7 +52,6 @@ describe('Host', function() {
 
     it('should not validate characters except letters, numbers and -', function() {
       expect(host.validate('aaa?bbb.ccc')).toBe(false);
-      expect(host.validate('aaa_bbb.ccc')).toBe(false);
       expect(host.validate('aaa+bbb.ccc')).toBe(false);
     });
 
@@ -68,15 +67,15 @@ describe('Host', function() {
   describe('sanitize', function() {
 
     it('should sanitize *', function() {
-      expect(host.sanitize('*')).toEqual(/^[a-z0-9-.]+$/);
+      expect(host.sanitize('*')).toEqual(/^[a-z0-9-_.]+$/);
     });
 
     it('should sanitize host without asterisk', function() {
       expect(host.sanitize('aaa')).toEqual(/^aaa$/);
     });
 
     it('should sanitize host with asterisk', function() {
-      expect(host.sanitize('*.aaa')).toEqual(/^([a-z0-9-.]+\.)?aaa$/);
+      expect(host.sanitize('*.aaa')).toEqual(/^([a-z0-9-_.]+\.)?aaa$/);
     });
 
   });
@@ -117,6 +116,11 @@ describe('Host', function() {
       expect(host.test('aaa.bbb.ccc', host.sanitize('aaa.bbb.xxx'))).toBe(false);
     });
 
+    it('should allow underscore in host', function () {
+      const pattern = host.sanitize('*');
+      expect(host.test('aaa_bbb', pattern)).toBe(true);
+    });
+
   });
 
 });