From 44f5c116b66ac24204879a6712ef90f9bc1efd01 Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Thu, 14 Apr 2022 18:07:29 -0400 Subject: [PATCH] chore: Killing auto assign / auto review since they add noise (#2546) * chore: Killing auto assign / auto review since they add noise Signed-off-by: Danny Chiao * Adding note to CONTRIBUTING.md Signed-off-by: Danny Chiao --- .github/CODEOWNERS | 4 ---- .github/workflows/assign_issues.yml | 15 --------------- .github/workflows/assign_reviewers.yml | 12 ------------ CONTRIBUTING.md | 3 +++ 4 files changed, 3 insertions(+), 31 deletions(-) delete mode 100644 .github/CODEOWNERS delete mode 100644 .github/workflows/assign_issues.yml delete mode 100644 .github/workflows/assign_reviewers.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index d92a420a40..0000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,4 +0,0 @@ -# Each line is a file pattern followed by one or more owners. -# https://help.github.com/en/articles/about-code-owners - -* @feast-dev/maintainers diff --git a/.github/workflows/assign_issues.yml b/.github/workflows/assign_issues.yml deleted file mode 100644 index f8702e2485..0000000000 --- a/.github/workflows/assign_issues.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: Issue assignment - -on: - issues: - types: [opened] - -jobs: - auto-assign: - runs-on: ubuntu-latest - steps: - - name: 'Auto-assign issue' - uses: pozil/auto-assign-issue@v1.1.0 - with: - assignees: achals, woop, tsotnet, felix, felixwang9817, adchia - numOfAssignee: 1 diff --git a/.github/workflows/assign_reviewers.yml b/.github/workflows/assign_reviewers.yml deleted file mode 100644 index ab776add0d..0000000000 --- a/.github/workflows/assign_reviewers.yml +++ /dev/null @@ -1,12 +0,0 @@ -name: 'Assign Reviewers' -on: - pull_request_target: - types: - - opened - - ready_for_review - -jobs: - add-reviews: - runs-on: ubuntu-latest - steps: - - uses: kentaro-m/auto-assign-action@v1.2.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1def64cf18..cb17012eea 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,6 +19,9 @@ A quick few highlights: - Includes biweekly community calls at 10AM PST ## Making a pull request +We use the convention that the assignee of a PR is the person with the next action. + +This means that often, the assignee may be empty (if no reviewer has been found yet), the reviewer, or the PR writer if there are comments to be addressed. ### Pull request checklist A quick list of things to keep in mind as you're making changes: