From 89ac9db228a5b1ab7befa1b013e00d2dae3f3972 Mon Sep 17 00:00:00 2001 From: ted chang Date: Tue, 20 Jul 2021 23:54:45 -0700 Subject: [PATCH] Fix unit test warnings related to file_url Signed-off-by: ted chang --- .../test_offline_online_store_consistency.py | 6 +++--- .../tests/integration/registration/test_feature_store.py | 6 +++--- sdk/python/tests/integration/registration/test_registry.py | 4 ++-- sdk/python/tests/utils/data_source_utils.py | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sdk/python/tests/integration/materialization/test_offline_online_store_consistency.py b/sdk/python/tests/integration/materialization/test_offline_online_store_consistency.py index 41741e0f96..5f4472b49e 100644 --- a/sdk/python/tests/integration/materialization/test_offline_online_store_consistency.py +++ b/sdk/python/tests/integration/materialization/test_offline_online_store_consistency.py @@ -199,7 +199,7 @@ def prep_local_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]: df.to_parquet(f.name) file_source = FileSource( file_format=ParquetFormat(), - file_url=f"file://{f.name}", + path=f"file://{f.name}", event_timestamp_column="ts", created_timestamp_column="created_ts", date_partition_column="", @@ -240,7 +240,7 @@ def prep_redis_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]: df.to_parquet(f.name) file_source = FileSource( file_format=ParquetFormat(), - file_url=f"file://{f.name}", + path=f"file://{f.name}", event_timestamp_column="ts", created_timestamp_column="created_ts", date_partition_column="", @@ -282,7 +282,7 @@ def prep_dynamodb_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]: df.to_parquet(f.name) file_source = FileSource( file_format=ParquetFormat(), - file_url=f"file://{f.name}", + path=f"file://{f.name}", event_timestamp_column="ts", created_timestamp_column="created_ts", date_partition_column="", diff --git a/sdk/python/tests/integration/registration/test_feature_store.py b/sdk/python/tests/integration/registration/test_feature_store.py index b842adcc77..b477aaba92 100644 --- a/sdk/python/tests/integration/registration/test_feature_store.py +++ b/sdk/python/tests/integration/registration/test_feature_store.py @@ -162,7 +162,7 @@ def test_apply_feature_view_success(test_feature_store): # Create Feature Views batch_source = FileSource( file_format=ParquetFormat(), - file_url="file://feast/*", + path="file://feast/*", event_timestamp_column="ts_col", created_timestamp_column="timestamp", date_partition_column="date_partition_col", @@ -279,7 +279,7 @@ def test_apply_feature_view_integration(test_feature_store): # Create Feature Views batch_source = FileSource( file_format=ParquetFormat(), - file_url="file://feast/*", + path="file://feast/*", event_timestamp_column="ts_col", created_timestamp_column="timestamp", date_partition_column="date_partition_col", @@ -346,7 +346,7 @@ def test_apply_object_and_read(test_feature_store): # Create Feature Views batch_source = FileSource( file_format=ParquetFormat(), - file_url="file://feast/*", + path="file://feast/*", event_timestamp_column="ts_col", created_timestamp_column="timestamp", ) diff --git a/sdk/python/tests/integration/registration/test_registry.py b/sdk/python/tests/integration/registration/test_registry.py index 82b0f51038..bd4d9dd9af 100644 --- a/sdk/python/tests/integration/registration/test_registry.py +++ b/sdk/python/tests/integration/registration/test_registry.py @@ -143,7 +143,7 @@ def test_apply_feature_view_success(test_registry): # Create Feature Views batch_source = FileSource( file_format=ParquetFormat(), - file_url="file://feast/*", + path="file://feast/*", event_timestamp_column="ts_col", created_timestamp_column="timestamp", date_partition_column="date_partition_col", @@ -212,7 +212,7 @@ def test_apply_feature_view_integration(test_registry): # Create Feature Views batch_source = FileSource( file_format=ParquetFormat(), - file_url="file://feast/*", + path="file://feast/*", event_timestamp_column="ts_col", created_timestamp_column="timestamp", date_partition_column="date_partition_col", diff --git a/sdk/python/tests/utils/data_source_utils.py b/sdk/python/tests/utils/data_source_utils.py index 3c25a697b7..99503b774c 100644 --- a/sdk/python/tests/utils/data_source_utils.py +++ b/sdk/python/tests/utils/data_source_utils.py @@ -14,7 +14,7 @@ def prep_file_source(df, event_timestamp_column=None) -> FileSource: df.to_parquet(f.name) file_source = FileSource( file_format=ParquetFormat(), - file_url=f.name, + path=f.name, event_timestamp_column=event_timestamp_column, ) yield file_source