From ee7fd87d94697e9e23bf971ecf0a3977ff0ba6f9 Mon Sep 17 00:00:00 2001 From: Pradithya Aria Date: Wed, 12 Dec 2018 14:27:28 +0800 Subject: [PATCH] Avoid returning error to caller when the query is successful but returns empty result. --- .../main/java/feast/serving/grpc/ServingGrpcService.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/serving/src/main/java/feast/serving/grpc/ServingGrpcService.java b/serving/src/main/java/feast/serving/grpc/ServingGrpcService.java index 8773e06375..6877ae33a3 100644 --- a/serving/src/main/java/feast/serving/grpc/ServingGrpcService.java +++ b/serving/src/main/java/feast/serving/grpc/ServingGrpcService.java @@ -77,14 +77,6 @@ public void queryFeatures(Request request, StreamObserver responseObse Request validRequest = checkTimestampRange(request); Response response = feast.queryFeatures(validRequest); - if (response.getEntitiesCount() < 1) { - responseObserver.onError( - new StatusRuntimeException( - Status.fromCode(NOT_FOUND) - .withDescription("No value is found for the requested feature"))); - return; - } - innerSpan.log("calling onNext"); responseObserver.onNext(response); innerSpan.log("calling onCompleted");