From be81c3f0646c5e9e3589106bc903598db3f80e18 Mon Sep 17 00:00:00 2001
From: Yuqing Wei <weiyuqing021@outlook.com>
Date: Tue, 10 Jan 2023 16:52:17 +0800
Subject: [PATCH] Fix delete entity function bug for #852 (#952)

---
 registry/access_control/api.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/registry/access_control/api.py b/registry/access_control/api.py
index 60c2a107d..005f226ba 100644
--- a/registry/access_control/api.py
+++ b/registry/access_control/api.py
@@ -25,12 +25,14 @@ async def get_project(project: str, response: Response, access: UserAccess = Dep
                                                    headers=get_api_header(access.user_name)))
     return res
 
+
 @router.get("/dependent/{entity}", name="Get downstream/dependent entitites for a given entity [Read Access Required]")
 def get_dependent_entities(entity: str, access: UserAccess = Depends(project_read_access)):
     response = requests.get(url=f"{registry_url}/dependent/{entity}",
                             headers=get_api_header(access.user_name)).content.decode('utf-8')
     return json.loads(response)
 
+
 @router.get("/projects/{project}/datasources", name="Get data sources of my project [Read Access Required]")
 def get_project_datasources(project: str, response: Response, access: UserAccess = Depends(project_read_access)) -> list:
     response.status_code, res = check(requests.get(url=f"{registry_url}/projects/{project}/datasources",
@@ -62,10 +64,13 @@ def get_feature(feature: str, response: Response, requestor: User = Depends(get_
         feature_qualifiedName, requestor, AccessType.READ)
     return res
 
+
 @router.delete("/entity/{entity}", name="Deletes a single entity by qualified name [Write Access Required]")
-def delete_entity(entity: str, access: UserAccess = Depends(project_write_access)) -> str:
-    requests.delete(url=f"{registry_url}/entity/{feature}",
-                               headers=get_api_header(access.user_name)).content.decode('utf-8')
+def delete_entity(entity: str, response: Response, access: UserAccess = Depends(project_write_access)) -> str:
+    response.status_code, res = check(requests.delete(
+        url=f"{registry_url}/entity/{entity}", headers=get_api_header(access.user_name)))
+    return res
+
 
 @router.get("/features/{feature}/lineage", name="Get Feature Lineage [Read Access Required]")
 def get_feature_lineage(feature: str, response: Response, requestor: User = Depends(get_user)) -> dict: