Show error dialog for typical engine troubles #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 26, 2020 20:22
|
I added another commit so that "Engine is down." is shown immediately (ref. #752 (comment)). This is an example of a wrong weight file (combined with #759). |
Closed
|
Oh, I wasn't aware of the big mistake.
LizzieFrame.java in this fix list I forgot to apply the part about 😥 This is an example of a mistake in the engine command "gtp"-> "tp".   |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many many users are confused by the misleading message "Engine is loading...". It will be better to show an error dialog immediately when Lizzie failed to start the engine, at least.