Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Edit job's data at failed / waiting tabs #478

Closed
n10000k opened this issue Oct 24, 2022 · 14 comments
Closed

Feature: Edit job's data at failed / waiting tabs #478

n10000k opened this issue Oct 24, 2022 · 14 comments
Labels
enhancement New feature or request

Comments

@n10000k
Copy link

n10000k commented Oct 24, 2022

The ability to edit the "data", save then it creates a log of what it previously was

@felixmosh
Copy link
Owner

Can you elaborate?

@n10000k
Copy link
Author

n10000k commented Oct 26, 2022

image

The ability to edit the paylod in data, let's say a job is failing due to a previous bug. You can quickly have the ability to update the value of data.

@felixmosh
Copy link
Owner

Duplicate of #425

@felixmosh felixmosh marked this as a duplicate of #425 Oct 27, 2022
@n10000k n10000k closed this as completed Oct 27, 2022
@n10000k n10000k reopened this Oct 27, 2022
@n10000k
Copy link
Author

n10000k commented Oct 27, 2022

Just checked that ticket, it's for creating only. This one is for editing the current job, what's your opinions on it? Like it's something i really need 😆

@felixmosh
Copy link
Owner

felixmosh commented Oct 27, 2022

So it's a duplicate of #426 :]
The ability to add a new job (with predefined params from an existing one).

We need to work on it.
Any help will be welcomed. :]

@n10000k
Copy link
Author

n10000k commented Oct 27, 2022

@felixmosh that would create a whole new job, i guess in this instance i want to keep the existing job and just update the redis value for data

@felixmosh
Copy link
Owner

felixmosh commented Oct 27, 2022

I don't think that editing an existing job is a good practice...
Think that you will need to move it to waiting as well.

How would you do that with code? is bull & bullmq supports it?

The suggested solution that I thought of, is to add a new job with duplicated data.

@n10000k
Copy link
Author

n10000k commented Oct 27, 2022

https://github.com/OptimalBits/bull/blob/master/REFERENCE.md#jobupdate

Looks like it's supported by bull here ^

Yeah, however if someone has some form of dependency on a job id also might have an issue with creating a new one.

@felixmosh felixmosh reopened this Oct 27, 2022
@felixmosh
Copy link
Owner

Ok, get your point.

@felixmosh felixmosh changed the title Edit data Feature: Edit job's data at failed / waiting tabs Oct 27, 2022
@felixmosh felixmosh added the enhancement New feature or request label Oct 27, 2022
@n10000k
Copy link
Author

n10000k commented Feb 7, 2023

@felixmosh any idea of an eta for this 🤞🏻

@felixmosh
Copy link
Owner

felixmosh commented Feb 7, 2023

I'm a bit busy lately... can't assure an ETA.
If this is an urgent feature for you, I'll happy to review a PR for this.

@Jcalcaldev
Copy link

Is this currently implemented?

@felixmosh
Copy link
Owner

Not yet ...

@felixmosh
Copy link
Owner

Released in v5.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants