Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Teams has twice notifications with one message #1675

Closed
awilliansd opened this issue Apr 11, 2024 · 10 comments
Closed

Microsoft Teams has twice notifications with one message #1675

awilliansd opened this issue Apr 11, 2024 · 10 comments

Comments

@awilliansd
Copy link

awilliansd commented Apr 11, 2024

Your issue

Version: 6.7.2
Server: Ferdium Server
Electron: 29.1.5
Chrome: 122.0.6261.130
Node.js: 20.9.0
Platform: Windows 11
Arch: x64
Git branch: release

I tried to look the code, but i didn't see any line that it has something about notifications.

@rmeissn
Copy link

rmeissn commented Apr 25, 2024

This does not seem to be related to MS Teams only, as I can observe it with WhatsApp and RocketChat too.
I'm getting notifications in the Gnome notification bar as two entries for one message. It should be only one entry.
I don't know whether this is related to my recent update to Gnome 46 (from 44) or to a recent Ferdium update.

Version: 6.7.2
Server: No Server
Electron: 29.1.5
Chrome: 122.0.6261.130
Node.js: 20.9.0
Platform: Linux 6.8
Arch: x64
Build date: Wed Mar 27 2024 15:09:46 GMT+0100 (Mitteleuropäische Normalzeit)
Git SHA: ce7a877
Git branch: release

@awilliansd
Copy link
Author

I think that it is ferdium, because i use Windows SO

@tulexx
Copy link

tulexx commented Apr 26, 2024

I only have MS Teams service which generates notifications, so I don't know about others. But what I noticed is that not only they are double, but also require a mouse click to disappear.

I had to resort to creating a custom recipe from the official one and adding onNotify which sets notification.options.requireInteraction to false and compares title and body with a previous one. If they're the same, I return null.

Version: 6.7.3
Server: No Server
Electron: 30.0.1
Chrome: 124.0.6367.60
Node.js: 20.11.1
Platform: Linux 5.15
Arch: x64
Build date: Thu Apr 25 2024 03:13:04 GMT+0200 (Central European Summer Time)
Git SHA: d8f519a
Git branch: release

@awilliansd
Copy link
Author

Where could I change this value??

@ponces
Copy link

ponces commented Apr 29, 2024

I only have MS Teams service which generates notifications, so I don't know about others. But what I noticed is that not only they are double, but also require a mouse click to disappear.

I had to resort to creating a custom recipe from the official one and adding onNotify which sets notification.options.requireInteraction to false and compares title and body with a previous one. If they're the same, I return null.

Version: 6.7.3 Server: No Server Electron: 30.0.1 Chrome: 124.0.6367.60 Node.js: 20.11.1 Platform: Linux 5.15 Arch: x64 Build date: Thu Apr 25 2024 03:13:04 GMT+0200 (Central European Summer Time) Git SHA: d8f519a Git branch: release

Could you please share it?

@tulexx
Copy link

tulexx commented Apr 29, 2024

Sure. This is the webview.js.

I used this documentation to find the recipe folder, created a dev subfolder there and copied the whole msteams folder into it and changed the webview.js. After restarting Ferdium, this new service is available under Custom Services.

@awilliansd
Copy link
Author

Thank you guy

@ponces
Copy link

ponces commented Apr 29, 2024

Why is this closed? Was the main recipe changed?

@typoworx-de
Copy link

Also asking myself why this has been closed shouldn't there be a merge request to fix the source in the msteams addon?

@typoworx-de
Copy link

I've created MR for this using @tulexx patch, thanks for your work
ferdium/ferdium-recipes#604

Alphrag pushed a commit to typoworx-de/ferdium-recipes that referenced this issue Dec 7, 2024
bugfix to merge this fix into official receipe for msteams:
https://gist.github.com/tulexx/54df51101366b329cbdcc050f9a9037c

discussed in issue ferdium/ferdium-app#1675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants