Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily use forked bindle #702

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Temporarily use forked bindle #702

merged 1 commit into from
Aug 22, 2022

Conversation

lann
Copy link
Collaborator

@lann lann commented Aug 19, 2022

We have backported a fix from bindle into a forked 0.8.1 tag. This fixes
a version constraint mismatch on indexmap which prevents upgrades to
wasmtime.

This should go away with #689

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge once CI is green.

We have backported a fix from bindle into a forked v0.8.1 tag. This fixes
a version constraint mismatch on `indexmap` which prevents upgrades to
`wasmtime`.

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann force-pushed the use-patched-bindle branch from fa11dbf to 1911973 Compare August 22, 2022 13:05
@lann
Copy link
Collaborator Author

lann commented Aug 22, 2022

Turns out Cargo doesn't reject unknown keys in the dependency spec and happily resolves as if the keys weren't there 🙁.

ref = "0.8.1" -> tag = "v0.8.1" fixed it

@lann lann merged commit 232567f into fermyon:main Aug 22, 2022
@lann lann deleted the use-patched-bindle branch October 20, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants