fix: feature detection for Google Chrome (#16)

fix: feature detection for Google Chrome
feross · Sep 10, 2019 · d106698 · d106698
2 parents 67bb860 + 2bd217a
commit d106698
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -20,7 +20,14 @@ var BIND_STATE_BOUND = 2
 // Track open sockets to route incoming data (via onReceive) to the right handlers.
 var sockets = {}
 
-if (typeof chrome !== 'undefined') {
+// Thorough check for Chrome App since both Edge and Chrome implement dummy chrome object
+if (
+  typeof chrome === 'object' &&
+  typeof chrome.runtime === 'object' &&
+  typeof chrome.runtime.id === 'string' &&
+  typeof chrome.sockets === 'object' &&
+  typeof chrome.sockets.udp === 'object'
+) {
   chrome.sockets.udp.onReceive.addListener(onReceive)
   chrome.sockets.udp.onReceiveError.addListener(onReceiveError)
 } else {