-
-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish new minor version #286
Comments
Sidenote: this might cause serious issues for WebTorrent clients since I can't force update the hundreds of websites that already have the WebTorrent library on them. It sounds like peers with a newer simple-peer won't be able to talk to the old ones? |
This renegotiate signal event is only sent if renegotiation is used. It is disabled by default and shouldn't cause issues for WebTorrent if the new features are never used by any WebTorrent peers. |
Just never use This could be considered semvar minor if the entire network doesn't use the new feature. Using the original featureset will work fine with old peers. |
Now that I'm thinking about it, this would be semvar minor. When not using the new renegotiation or multi-streaming features, interop works perfectly fine with older versions. Only when using new features does backward compatibility break. |
Nice, thanks for the explanation. I'll release this as a minor version then. |
Will publish when |
Not passing, still blocked on #283 |
Published 9.1.0! Thanks @rationalcoding! |
Following on my comment here: #250 (comment)
Usually, whenever I make a breaking change, I make the commit message start with
BREAKING:
so that users upgrading to the new major version can quickly scan for the breaking commit. In that commit, I write what is breaking and what (if anything) the user can do to migrate.@rationalcoding Can you write up a description and rationale for the breakage?
Once this is documented here, I can release a new major version and include the message in the version commit, which will be fine for this release.
The text was updated successfully, but these errors were encountered: