From 594c3e8bf450abc5271644508bbadb44e0a79a1a Mon Sep 17 00:00:00 2001 From: Lukas Fellechner Date: Sun, 26 Jun 2022 21:30:05 +0200 Subject: [PATCH 1/2] Fix basic video effect --- Source/VideoEffectConfiguration.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Source/VideoEffectConfiguration.h b/Source/VideoEffectConfiguration.h index 469f10bb72..fbf2eaf88c 100644 --- a/Source/VideoEffectConfiguration.h +++ b/Source/VideoEffectConfiguration.h @@ -111,7 +111,7 @@ namespace FFmpegInteropX { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInterop.BasicVideoEffect", true, set); + player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", true, set); } [Windows::Foundation::Metadata::DefaultOverloadAttribute] @@ -119,21 +119,21 @@ namespace FFmpegInteropX { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInterop.BasicVideoEffect", optional, set); + player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", optional, set); } void AddVideoEffect(MediaElement^ player) { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInterop.BasicVideoEffect", true, set); + player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", true, set); } void AddVideoEffect(MediaElement^ player, bool optional) { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInterop.BasicVideoEffect", optional, set); + player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", optional, set); } }; -} \ No newline at end of file +} From 4009e43919efb05b924cafd49101f96187473398 Mon Sep 17 00:00:00 2001 From: brabebhin Date: Tue, 28 Jun 2022 09:22:56 +0300 Subject: [PATCH 2/2] use const for activatable class id --- Source/VideoEffectConfiguration.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Source/VideoEffectConfiguration.h b/Source/VideoEffectConfiguration.h index fbf2eaf88c..82d26dde3f 100644 --- a/Source/VideoEffectConfiguration.h +++ b/Source/VideoEffectConfiguration.h @@ -18,7 +18,7 @@ namespace FFmpegInteropX float _Tint; float _Sharpness; float _SharpnessThreshold; - + String^ classId = "FFmpegInteropX.BasicVideoEffect"; public: ///Adjusts the brightness of the image. Default value is 0, recommended range -1 to 1. property float Brightness @@ -111,7 +111,7 @@ namespace FFmpegInteropX { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", true, set); + player->AddVideoEffect(classId, true, set); } [Windows::Foundation::Metadata::DefaultOverloadAttribute] @@ -119,21 +119,21 @@ namespace FFmpegInteropX { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", optional, set); + player->AddVideoEffect(classId, optional, set); } void AddVideoEffect(MediaElement^ player) { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", true, set); + player->AddVideoEffect(classId, true, set); } void AddVideoEffect(MediaElement^ player, bool optional) { PropertySet^ set = ref new PropertySet(); set->Insert("config", this); - player->AddVideoEffect("FFmpegInteropX.BasicVideoEffect", optional, set); + player->AddVideoEffect(classId, optional, set); } }; }