Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] V11 compatibility #7

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

[TASK] V11 compatibility #7

wants to merge 63 commits into from

Conversation

calien666
Copy link
Member

No description provided.

calien666
calien666 commented Apr 22, 2024
View reviewed changes
Copy link
Member Author

@calien666 calien666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Riiiad Take a look here.

.ddev/addon-metadata/phpmyadmin/manifest.yaml Outdated Show resolved Hide resolved
.ddev/apache/apache-site.conf Outdated Show resolved Hide resolved
.ddev/docker-compose.phpmyadmin-norouter.yaml Outdated Show resolved Hide resolved
.ddev/docker-compose.phpmyadmin.yaml Outdated Show resolved Hide resolved
Classes/Extbase/TypeConverter/BasePollObjectConverterV9.php Outdated Show resolved Hide resolved
Resources/Private/Partials/Poll/List/Table.html Show resolved Hide resolved
rector.php Show resolved Hide resolved
@PKuhlmay
Copy link

PKuhlmay commented May 29, 2024 •
edited
Loading

The Readme file needs to be adjusted as well. The command "ddev install-full" is not available anymore.
Done ✅

PKuhlmay
PKuhlmay reviewed May 29, 2024
View reviewed changes
rector.php Outdated Show resolved Hide resolved
rector.php Outdated Show resolved Hide resolved
Resources/Private/Partials/Poll/List/Table.html Show resolved Hide resolved
rector.php Show resolved Hide resolved
This was referenced May 29, 2024
Open
Closed
@Riiiad Riiiad force-pushed the update-11-lts branch 7 times, most recently from e139ccc to 525fc3d Compare October 7, 2024 11:57
PKuhlmay
PKuhlmay reviewed Oct 7, 2024
View reviewed changes
.ddev/config.yaml Outdated Show resolved Hide resolved
Riiiad and others added 25 commits October 7, 2024 14:26
@Riiiad
[TASK] Move admin check method to Service class
dfa57c3
@Riiiad
[TASK] Add correct constrain for finished polls and list view update
493c8c0
@Riiiad
[TASK] Show correct list view with and without paginated items
e726cd0
@Riiiad
[TASK] Add basic bootstrap pagination and remove old markup
2b81a0a
@calien666 @Riiiad
[TASK] Add use instead of full qualified namespaces
85b9f6d
@calien666 @Riiiad
[TASK] Move inject methods to the top
9159f54 
To have a quick overview, the inject methods for repositories where
moved to the top of the class. This allows a faster view of how the
dependencies are injected
@calien666 @Riiiad
[TASK] clean-up ddev config
241da79 
* Remove phpmyadmin dependency
* Remove auto-generated config files
@calien666 @Riiiad
[TASK] Update git config
366cb5e
@calien666 @Riiiad
[TASK] Refactor view var assignment
6168e77
@calien666 @Riiiad
[TASK] Finalize events and code-style-fix
399cbc2
@calien666 @Riiiad
[TASK] Finalize events and code-style-fix
162a85b
@calien666 @Riiiad
[BUGFIX] Reset poll slug default to empty string
e4129db
@Riiiad
[TASK] Add makefile for rendering documentation locally
fabfecc
@Riiiad
[TASK] Set version of extension to 0.10 and update typo3 dependencies
0429679
@Riiiad
[DOCS] Update and fix documentation
1554064
@Riiiad
[TASK] Update Readme - remove old ddev commands and set correct image…
6bf75e5 
… sizes
@Riiiad
[TASK] Fix rector config
825b5c8
@Riiiad
[TASK] Add PHP Doc Comment for throwing an exception in PollControlle…
03c4a49 
…r::publishAction
@Riiiad
[BUGFIX] Hide pagination when there is only one page to be displayed
bf8a0d2
@Riiiad
[TASK] Update runTests.sh configuration
8f8875b
@Riiiad
[TASK] Add gihub actions
d0cbee9
@Riiiad
[TASK] Steamline configuration and scripts for linters
c2576cf
@Riiiad
[TASK] Fix Errors found by checkExceptionCodes command
911b57e
@Riiiad
[TASK] Correct return types, properties and parameters
95558ac 
Resolve PHPStan reported issues till level 5 as preperation for future upgrades
@Riiiad
[TASK] Generate baseline for phpstan errors
e373a80
calien666
calien666 commented Oct 16, 2024
View reviewed changes
Copy link
Member Author

@calien666 calien666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Riiiad Made some comments, additionally we should add a milestone for v12/v13, adding things like removing renderStatic from ViewHelpers, as this is deprecated since fluid v4.

Classes/Controller/PollController.php Show resolved Hide resolved
Classes/Controller/PollController.php Show resolved Hide resolved
Classes/Controller/PollController.php Show resolved Hide resolved
Classes/Controller/PollController.php Show resolved Hide resolved
Classes/Controller/PollController.php Show resolved Hide resolved
Documentation/Settings.cfg Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
ext_emconf.php Outdated Show resolved Hide resolved
rector.php Show resolved Hide resolved
@calien666 calien666 linked an issue Oct 16, 2024 that may be closed by this pull request
Upgrade for v11? #5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKuhlmay PKuhlmay PKuhlmay left review comments

@Riiiad Riiiad Riiiad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade for v11?
4 participants
@calien666 @PKuhlmay @Riiiad @andreaswolf