Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of entry.sh / question on contributing #138

Closed
HaraldR42 opened this issue Sep 17, 2023 · 3 comments · Fixed by #139
Closed

Rewrite of entry.sh / question on contributing #138

HaraldR42 opened this issue Sep 17, 2023 · 3 comments · Fixed by #139

Comments

@HaraldR42
Copy link
Contributor

Dear maintainers,

I did a fairly massive rewrite of the entry.sh script. It mainly addresses:

  • In the past there were a number of regressions in sending the log to the console.
    With my new version, sending the log to the console is done by a background process heavily using "tail",
    but also taking care of line-buffering, changed log file etc.
    And performance wise it uses much less calls to the various unix tools, as it doesn't poll any more.
  • Checking for process startup and process termination is more robust.
  • General rewrite, making the script more modular and robust.

So my question is: Should I make a pull request on the original entry.sh, resulting in a massive (and mostly useless diff),
or should I request pulling a new file?

Thx in advance
Harald

@sidey79
Copy link
Contributor

sidey79 commented Sep 17, 2023

You can open a PR. May i then start multiple discussions for a better understanding.

@sidey79 sidey79 linked a pull request Mar 2, 2024 that will close this issue
@sidey79
Copy link
Contributor

sidey79 commented Mar 4, 2024

Your updated script will be included in version 4 of the image

@HaraldR42
Copy link
Contributor Author

Hi @sidey79 ,
Thanks a lot for your additional contributions, and thanks for merging!
Cheers,
Harald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants