Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix importMeta error by updating to stylelint 16 #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix importMeta error by updating to stylelint 16 #294

wants to merge 1 commit into from
+199 −285

Conversation

strawberry-choco
Copy link

This fixes #260 .

I am not sure if we can or should update stylelint directly to 16, since its release was quite recent. Thus, I updated only to 15 instead.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e3dfb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 0e3dfb6
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/66a7328d6ce4ab0009309400
😎 Deploy Preview https://deploy-preview-294--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@strawberry-choco strawberry-choco changed the title feat: fix importMeta error by updating to stylelint 15 fix: fix importMeta error by updating to stylelint 15 Jan 5, 2024
@tryforceful
Copy link

@fi3ework Now that this repo is being maintained again (🎉🙏🏼), can someone look at this PR to see if it can be merged?

Latest versions of stylelint are blocked by this meow package issue.

Perhaps the node v20 CI issue is just a fluke like the other recent findings about the CI being unstable? 😬

tryforceful
tryforceful approved these changes Jul 1, 2024
View reviewed changes
Copy link

@tryforceful tryforceful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would want @fi3ework 's review

@strawberry-choco strawberry-choco changed the title fix: fix importMeta error by updating to stylelint 15 fix: fix importMeta error by updating to stylelint 16 Jul 2, 2024
@strawberry-choco
Copy link
Author

strawberry-choco commented Jul 2, 2024 •
edited
Loading

Updated the PR to stylelint 16 now.

@strawberry-choco
Copy link
Author

Will fix the builds when I have time. I have been quite busy recently.

@fi3ework
Copy link
Owner

I'll check the PR later.

@strawberry-choco strawberry-choco force-pushed the importMetaFix branch 3 times, most recently from 3cf1de1 to dd4c44d Compare July 17, 2024 19:33
@strawberry-choco
Copy link
Author

Got the PR mostly working. Only node18 is failing for some reason.

@strawberry-choco
Copy link
Author

strawberry-choco commented Jul 29, 2024 •
edited
Loading

@fi3ework Works now. :)

@tryforceful
Copy link

@fi3ework can you please merge this if you agree? 🙏🏼

@liyasthomas
Copy link

Waiting for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tryforceful tryforceful tryforceful approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

latest vite-plugin-checker@0.6.1 doesn't work well with meow@10 (from latest stylelint v15.10.1)
4 participants
@strawberry-choco @tryforceful @fi3ework @liyasthomas