Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ec2 shear #16

Merged
merged 11 commits into from
Oct 2, 2023
Merged

feat: Ec2 shear #16

merged 11 commits into from
Oct 2, 2023

Conversation

GEumel
Copy link
Contributor

@GEumel GEumel commented Mar 7, 2023

Original code from previous project.

@mortenengen mortenengen changed the base branch from concrete-class to dev March 8, 2023 19:48
@mortenengen mortenengen changed the title Ec2 shear feat: Ec2 shear Mar 8, 2023
@GEumel GEumel marked this pull request as ready for review May 8, 2023 11:56
@mortenengen
Copy link
Member

@GEumel our pipeline stops at black. Please run black and linting, fix so that it runs without errors, and resubmit 😄

@GEumel
Copy link
Contributor Author

GEumel commented Jun 2, 2023

@mortenengen I've reformatted the code using black. It should work now without errors.

@mortenengen
Copy link
Member

Thanks, @GEumel 👍 Remember to also run the linters, see the bottom of this page here.

…tests/test_ec2_shear.py comply with flake8 and pylint.
@GEumel
Copy link
Contributor Author

GEumel commented Jun 2, 2023

@mortenengen I figured a warning from the linters would not break the checks performed here. I made small adjustments to the code to comply with the linters. Locally I do not get any warnings from the linters anymore (or black).

@mortenengen
Copy link
Member

All good! Thanks, @GEumel, I will make sure this gets reviewed.

@mortenengen mortenengen added the enhancement New feature or request label Jun 2, 2023
Copy link
Collaborator

@DanielGMorenaFhecor DanielGMorenaFhecor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I found it very inspirational and I will use some of your ideas in my following code lines!

structuralcodes/codes/ec2/__init__.py Outdated Show resolved Hide resolved
structuralcodes/codes/ec2/shear.py Outdated Show resolved Hide resolved
structuralcodes/codes/ec2/shear.py Outdated Show resolved Hide resolved
structuralcodes/codes/ec2/shear.py Outdated Show resolved Hide resolved
structuralcodes/codes/ec2/shear.py Outdated Show resolved Hide resolved
structuralcodes/codes/ec2/shear.py Outdated Show resolved Hide resolved
structuralcodes/codes/ec2/shear.py Outdated Show resolved Hide resolved
@mortenengen
Copy link
Member

@GEumel: could you please have a look and add a fix so that the 3.7 pipeline runs without errors? It seems to be related to an ambiguous variable name.

@DanielGMorenaFhecor: could you please review the latest changes?

@GEumel
Copy link
Contributor Author

GEumel commented Aug 10, 2023

@mortenengen I have changed the variable name, hopefully it also runs now in 3.7 without errors. I find it strange though that it worked fine in the other versions.

Copy link
Collaborator

@DanielGMorenaFhecor DanielGMorenaFhecor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved changes in GitHub repo. 👍

@DanielGMorenaFhecor
Copy link
Collaborator

I have just reviewed the changes! @mortenengen should we already merge this branch with dev?

@mortenengen
Copy link
Member

Very good @DanielGMorenaFhecor and @GEumel. I will do the merge and close the PR 😃

@mortenengen mortenengen merged commit 876d2bd into fib-international:dev Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Add example implementation of code formulas Implementation of shear formulas EN1992-1-1 and prEN1992-1-1
3 participants