-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ec2 shear #16
feat: Ec2 shear #16
Conversation
…lcodes/codes/shear.py.
@GEumel our pipeline stops at black. Please run black and linting, fix so that it runs without errors, and resubmit 😄 |
…_ec2_shear.py using black.
@mortenengen I've reformatted the code using black. It should work now without errors. |
…tests/test_ec2_shear.py comply with flake8 and pylint.
@mortenengen I figured a warning from the linters would not break the checks performed here. I made small adjustments to the code to comply with the linters. Locally I do not get any warnings from the linters anymore (or black). |
All good! Thanks, @GEumel, I will make sure this gets reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I found it very inspirational and I will use some of your ideas in my following code lines!
@GEumel: could you please have a look and add a fix so that the 3.7 pipeline runs without errors? It seems to be related to an ambiguous variable name. @DanielGMorenaFhecor: could you please review the latest changes? |
@mortenengen I have changed the variable name, hopefully it also runs now in 3.7 without errors. I find it strange though that it worked fine in the other versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Approved changes in GitHub repo. 👍
I have just reviewed the changes! @mortenengen should we already merge this branch with |
Very good @DanielGMorenaFhecor and @GEumel. I will do the merge and close the PR 😃 |
Original code from previous project.