From a7325fd93ad4090acc26e47baabce2d41bb45948 Mon Sep 17 00:00:00 2001
From: Filipe Forattini <filipe@vitta.me>
Date: Thu, 7 Jul 2022 17:35:30 -0300
Subject: [PATCH] typo: correct service type

---
 deploy/as-k8s/service.schema.yml              |  5 ++--
 deploy/as-k8s/service/4-service.yml           | 24 ++++++++++++-------
 ...vc-service-nlb.yml => svc-service-aws.yml} |  4 ++--
 test/cases/svc-service.sh                     |  4 ++--
 4 files changed, 22 insertions(+), 15 deletions(-)
 rename test/assets/{svc-service-nlb.yml => svc-service-aws.yml} (90%)

diff --git a/deploy/as-k8s/service.schema.yml b/deploy/as-k8s/service.schema.yml
index f824cfa4..d6d80a2f 100644
--- a/deploy/as-k8s/service.schema.yml
+++ b/deploy/as-k8s/service.schema.yml
@@ -16,7 +16,8 @@
 #@ def defaultService():
   enable: true
   name: svc
-  type: simple
+  type: ClusterIP
+  controller: null
 
   #@schema/type any=True
   labels: null
@@ -35,7 +36,7 @@
     domain: acme.io
 
   #! types specifics
-  nlb:
+  aws:
     internal: true
     sslCert: secret
     nodeTabels: ""
diff --git a/deploy/as-k8s/service/4-service.yml b/deploy/as-k8s/service/4-service.yml
index 8a1c0b4a..9a6e9835 100644
--- a/deploy/as-k8s/service/4-service.yml
+++ b/deploy/as-k8s/service/4-service.yml
@@ -21,29 +21,35 @@ metadata:
   #@    })
   #@  end
 
-  #@  if data.values.service.type == "nlb":
+  #@  if data.values.service.controller == "aws":
   #@    serviceAnnotations.update({
   #@      "service.beta.kubernetes.io/aws-load-balancer-type": "nlb",
-  #@      "service.beta.kubernetes.io/aws-load-balancer-internal": "{}".format(data.values.service.nlb.internal).lower(),
+  #@      "service.beta.kubernetes.io/aws-load-balancer-internal": "{}".format(data.values.service.aws.internal).lower(),
   #@      "service.beta.kubernetes.io/aws-load-balancer-backend-protocol": "http",
   #@      "service.beta.kubernetes.io/aws-load-balancer-connection-draining-enabled": "true",
   #@      "service.beta.kubernetes.io/aws-load-balancer-connection-draining-timeout": "60",
   #@      "service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled": "true",
-  #@      "service.beta.kubernetes.io/aws-load-balancer-ssl-cert": data.values.service.nlb.sslCert,
+  #@      "service.beta.kubernetes.io/aws-load-balancer-ssl-cert": data.values.service.aws.sslCert,
   #@      "service.beta.kubernetes.io/aws-load-balancer-ssl-ports": "443",
-  #@      "service.beta.kubernetes.io/aws-load-balancer-target-node-labels": data.values.service.nlb.nodeTabels,
+  #@      "service.beta.kubernetes.io/aws-load-balancer-target-node-labels": data.values.service.aws.nodeTabels,
   #@    })
   #@  end
   annotations: #@ serviceAnnotations
 
 spec:
-  #@ if data.values.service.selector.overwrite:
+  #@  if data.values.service.controller != None:
+  type: LoadBalancer
+  #@  else:
+  type: #@ data.values.service.type
+  #@  end
+
+  #@  if data.values.service.selector.overwrite:
   selector: #@ data.values.service.selector.labels
-  #@ else:
-  #@ serviceMatchLabels = {}
-  #@ serviceMatchLabels.update({ "pipe/selector": data.values.repository + "." + data.values.deployment.name })
+  #@  else:
+  #@    serviceMatchLabels = {}
+  #@    serviceMatchLabels.update({ "pipe/selector": data.values.repository + "." + data.values.deployment.name })
   selector: #@ serviceMatchLabels
-  #@ end
+  #@  end
 
   #@ servicePorts = []
   #@ servicePorts.extend(data.values.service.ports)
diff --git a/test/assets/svc-service-nlb.yml b/test/assets/svc-service-aws.yml
similarity index 90%
rename from test/assets/svc-service-nlb.yml
rename to test/assets/svc-service-aws.yml
index ccabc068..64b57f5a 100644
--- a/test/assets/svc-service-nlb.yml
+++ b/test/assets/svc-service-aws.yml
@@ -7,7 +7,7 @@ env:
     value: America/Sao_Paulo
 
 service:
-  type: nlb
+  controller: aws
   annotations:
     A: "1"
     B: "2"
@@ -15,6 +15,6 @@ service:
   externalDns:
     enable: true
     domain: acme.io
-  nlb:
+  aws:
     internal: true
     sslCert: secret
diff --git a/test/cases/svc-service.sh b/test/cases/svc-service.sh
index 0acd5aa5..9227b56a 100644
--- a/test/cases/svc-service.sh
+++ b/test/cases/svc-service.sh
@@ -8,5 +8,5 @@ ytt \
 ytt \
   -f $DIR_SRC/service.schema.yml \
   -f $DIR_SRC/service \
-  -f $DIR_ASSETS/svc-service-nlb.yml \
-    > $DIR_RESULTS/src-service-2-nlb.yml
+  -f $DIR_ASSETS/svc-service-aws.yml \
+    > $DIR_RESULTS/src-service-2-aws.yml