Skip to content

Commit

Permalink
fixed the wrong code example in DesktopAgeng.md too, update changelog
Browse files Browse the repository at this point in the history
Signed-off-by: Yao, Yao <donghong.yao@fmr.com>
  • Loading branch information
YaoYao-dd committed Sep 10, 2024
1 parent 71cd5df commit 164762b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Added missing `desktopAgent` field to ImplementationMetadata objects returned for all agents connect to a DesktopAgent bridge in Connection Step 6 connectAgentsUpdate messages and refined the schema used to collect this info in step 3 handshake. ([#1177](https://github.com/finos/FDC3/pull/1177))
* Removed the `version` field from `IntentResolution` as there are no version fields for intents in the FDC3 API definitions and hence the field has no purpose. ([#1170](https://github.com/finos/FDC3/pull/1170))

* Fixed an error in the Client-side example from `PrivateChannel` document as 'symbol' is misused, 'ticker' should be used to align with sever-side example, also align with instrument type standard. ([#1314](https://github.com/finos/FDC3/pull/1314))
* Fixed error in the Client-side example from `PrivateChannel` and `addIntentListener` by correcting `id.symbol` to `id.ticker` to align with the `fdc3.instrument` context. ([#1314](https://github.com/finos/FDC3/pull/1314))

## [npm v2.1.1] - 2024-06-28

Expand Down
2 changes: 1 addition & 1 deletion docs/api/ref/DesktopAgent.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ fdc3.addIntentListener("CreateOrder", (context) => {
//Handle a raised intent and return a PrivateChannel over which response will be sent
fdc3.addIntentListener("QuoteStream", async (context) => {
const channel: PrivateChannel = await fdc3.createPrivateChannel();
const symbol = context.id.symbol;
const symbol = context.id.ticker;
// Called when the remote side adds a context listener
const addContextListener = channel.onAddContextListener((contextType) => {
Expand Down
2 changes: 1 addition & 1 deletion website/versioned_docs/version-2.0/api/ref/DesktopAgent.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ fdc3.addIntentListener("CreateOrder", (context) => {
//Handle a raised intent and return a PrivateChannel over which response will be sent
fdc3.addIntentListener("QuoteStream", async (context) => {
const channel: PrivateChannel = await fdc3.createPrivateChannel();
const symbol = context.id.symbol;
const symbol = context.id.ticker;
// Called when the remote side adds a context listener
const addContextListener = channel.onAddContextListener((contextType) => {
Expand Down
2 changes: 1 addition & 1 deletion website/versioned_docs/version-2.1/api/ref/DesktopAgent.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ fdc3.addIntentListener("CreateOrder", (context) => {
//Handle a raised intent and return a PrivateChannel over which response will be sent
fdc3.addIntentListener("QuoteStream", async (context) => {
const channel: PrivateChannel = await fdc3.createPrivateChannel();
const symbol = context.id.symbol;
const symbol = context.id.ticker;
// Called when the remote side adds a context listener
const addContextListener = channel.onAddContextListener((contextType) => {
Expand Down

0 comments on commit 164762b

Please sign in to comment.