From 9adeacc47dd0ee9b2ee3fb93f8f02626e6b29193 Mon Sep 17 00:00:00 2001 From: sgd2z Date: Wed, 3 Jun 2020 16:43:18 -0400 Subject: [PATCH 1/3] Allow displayMetaData to be specified at Channel creation time --- src/api/DesktopAgent.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/api/DesktopAgent.ts b/src/api/DesktopAgent.ts index d19afa3ca..9cdf9298b 100644 --- a/src/api/DesktopAgent.ts +++ b/src/api/DesktopAgent.ts @@ -144,7 +144,9 @@ interface DesktopAgent { * It is up to applications to manage how to share knowledge of these custom channels across windows and to manage * channel ownership and lifecycle. * + * If `displayMetaData` is specified, the channel is visually selectable by the user + * * `Error` with a string from the `ChannelError` enumeration. */ - getOrCreateChannel(channelId: string): Promise; + getOrCreateChannel(channelId: string, displayMetaData?: DisplayMetaData): Promise; } \ No newline at end of file From fbcc95bb0279c6bd637612156f7559e0bfcf5cf7 Mon Sep 17 00:00:00 2001 From: sgd2z Date: Wed, 3 Jun 2020 17:43:08 -0400 Subject: [PATCH 2/3] comment --- src/api/DesktopAgent.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/api/DesktopAgent.ts b/src/api/DesktopAgent.ts index 9cdf9298b..8368b3311 100644 --- a/src/api/DesktopAgent.ts +++ b/src/api/DesktopAgent.ts @@ -144,7 +144,7 @@ interface DesktopAgent { * It is up to applications to manage how to share knowledge of these custom channels across windows and to manage * channel ownership and lifecycle. * - * If `displayMetaData` is specified, the channel is visually selectable by the user + * If `displayMetaData` is specified, the channel is visually selectable by the user. If the channel already exists, displayMetaData is ignored. * * `Error` with a string from the `ChannelError` enumeration. */ From bb788174550a26db2583db87ae37991c330094fc Mon Sep 17 00:00:00 2001 From: sgd2z Date: Wed, 16 Sep 2020 13:13:56 -0400 Subject: [PATCH 3/3] update spelling --- src/api/DesktopAgent.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/api/DesktopAgent.ts b/src/api/DesktopAgent.ts index 4d67e4fb0..310768889 100644 --- a/src/api/DesktopAgent.ts +++ b/src/api/DesktopAgent.ts @@ -144,11 +144,11 @@ interface DesktopAgent { * It is up to applications to manage how to share knowledge of these custom channels across windows and to manage * channel ownership and lifecycle. * - * If `displayMetaData` is specified, the channel is visually selectable by the user. If the channel already exists, displayMetaData is ignored. + * If `displayMetadata` is specified, the channel is visually selectable by the user. If the channel already exists, displayMetadata is ignored. * * `Error` with a string from the `ChannelError` enumeration. */ - getOrCreateChannel(channelId: string, displayMetaData?: DisplayMetaData): Promise; + getOrCreateChannel(channelId: string, displayMetadata?: DisplayMetadata): Promise; /** * Returns the `Channel` object for the current channel membership.