Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEAN BAPTISTE ZIADE ObservationTerms_ValuationTerms_FRAGMOS #3227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regnosys-prod-user
Copy link
Collaborator

No description provided.

make these two types generic (info : pleas ignore presence of observable in ObservationTerms, agreed to remove it per ARTForce)
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit 37c467e
🔍 Latest deploy log https://app.netlify.com/sites/finos-cdm/deploys/672cbfb03ccf140008796226
😎 Deploy Preview https://deploy-preview-3227--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JBZ-Fragmos JBZ-Fragmos added Status: draft only Draft, for discussion only. Contributor still working on build Status: needs review Needs to be reviewed by Maintainer Complexity: Minor Change Requires two TA approval Criticality: High Target: Development labels Nov 7, 2024
@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Nov 7, 2024

Background :

Target :

  • merge any agreed components into Dev, before next major release that will incorporate such changes into Prod

Method proposal : give, the fact this PR contains a lot of proposal changes :

  • though Fragmos would be very happy to get consensus for the whole PR,
  • we understand opportunity to split / create new individual PR whenever there would be consensus for "cherry picking" sub-sets of changes among the whole set being present in the original "big" PR - that is to say, if potential split may be considered, please reach out ->Fragmos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Minor Change Requires two TA approval Criticality: High Rosetta Status: draft only Draft, for discussion only. Contributor still working on build Status: needs review Needs to be reviewed by Maintainer Target: Development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants