-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docusaurus #138
Add docusaurus #138
Conversation
✅ Deploy Preview for lucky-concha-f3599f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mimiflynn, FYI |
|
ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../{docs,website}/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheJuanAndOnly99 , we tried quite a few combination of this - and ended up just by using /bin/false . If you figure out a working setup (that works for the draft pages too and for normal, etc), I am super interested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @psmulovics not sure I understand what you mean by draft vs normal pages. The objective here is to only run Netlify on PRs that contain changes to the docs and website folders.
@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge? |
Is the intent just to get the docs project in the build, as obviously the docs themselves are missing other than the front page? If so the setup looks fine to me, but I can't merge as I don't have write access to the repo. Which raises the question should we be adding CODEOWNERS into this repo and broadening the maintainer list? @maoo / @DovOps |
Good points. Here's my proposal:
Thoughts? |
@maoo I suggest we merge this - good with perm changes. And we can make additional changes once this is properly in the build |
#133 This PR adds Docusaurus v3.