Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial conversion of main services - build and deploy #206

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

matthewgardner
Copy link
Member

@matthewgardner matthewgardner commented Aug 31, 2024

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS Corporate Contributor License Agreement.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

#203

Complete

  • Added Tilt file for local execution
  • Added Base k8s config
  • Added Yaml for most services
  • Simple Port Ingress (will revisit in another PR)

Copy link

linux-foundation-easycla bot commented Aug 31, 2024

CLA Missing ID CLA Not Signed

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for lucky-concha-f3599f canceled.

Name Link
🔨 Latest commit 341a1b3
🔍 Latest deploy log https://app.netlify.com/sites/lucky-concha-f3599f/deploys/66e1e91c296cb1000853d177

DovOps and others added 2 commits September 3, 2024 14:58
@DovOps
Copy link
Contributor

DovOps commented Sep 3, 2024

@matthewgardner once we sort out the CLA situation, we're ready to merge this. I think you can do this by clicking the red CLA button above.

@DovOps DovOps marked this pull request as ready for review September 9, 2024 15:52
@DovOps DovOps self-assigned this Sep 9, 2024
@bingenito
Copy link
Member

/easycla

1 similar comment
@bingenito
Copy link
Member

/easycla

@matthewgardner matthewgardner marked this pull request as draft September 9, 2024 16:10
@matthewgardner
Copy link
Member Author

matthewgardner commented Sep 10, 2024

  • Added Nginx Ingress
  • Added to readme for how to add to local cluster

Testing evidence below:
Screenshot 2024-09-10 at 21 02 29

Suggestions for future pr (out of scope of this PR?) is to enable health endpoints on service so make it easy to spot when services are actually ready.

@matthewgardner matthewgardner marked this pull request as ready for review September 10, 2024 20:16
@DovOps
Copy link
Contributor

DovOps commented Sep 11, 2024

Suggestions for future pr (out of scope of this PR?) is to enable health endpoints on service so make it easy to spot when services are actually ready.

Definitely. See issue #124

@DovOps
Copy link
Contributor

DovOps commented Sep 12, 2024

/easycla

@DovOps
Copy link
Contributor

DovOps commented Sep 12, 2024

@bingenito @maoo @karlmoll - Need a bit of help sorting out the easyCLA issue, as it has to do with a commit from me that is not using the right e-mail. Tried fixing this but it did not work. Once done we can merge this, unless we should merge and note the exception.

@maoo
Copy link
Member

maoo commented Sep 12, 2024

@bingenito @maoo @karlmoll - Need a bit of help sorting out the easyCLA issue, as it has to do with a commit from me that is not using the right e-mail. Tried fixing this but it did not work. Once done we can merge this, unless we should merge and note the exception.

@DovOps , could you please confirm that the email address that you see on https://api.github.com/repos/finos/traderX/commits/cd9ffec6febfe75913dcf95e26e0b1682e75c79f is also on https://github.com/settings/emails ?

In parallel, I'd also check git config --list | grep email to make sure which email you use to sign commits; another - maybe longer - option is to update the user.email config, git reset and then commit again on @matthewgardner branch.

@DovOps
Copy link
Contributor

DovOps commented Sep 12, 2024

@maoo it's the noreply one for me, which apparently was in my settings on the local repo for some reason. I'll try a git reset + commit if that works

@DovOps
Copy link
Contributor

DovOps commented Sep 12, 2024

This did not succeed. Merging this as-is. @bingenito can confirm that @DovOps (author of cd9ffec ) has agreed to CLA.

@DovOps DovOps merged commit b5a53b2 into finos:main Sep 12, 2024
4 of 5 checks passed
@bingenito
Copy link
Member

This did not succeed. Merging this as-is. @bingenito can confirm that @DovOps (author of cd9ffec ) has agreed to CLA.

As CLA Manager for Morgan Stanley I confirm that @DovOps is covered under our EasyCLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants