Fix memory leak, switch to auto managed clients and bug fix #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x dialog hanging around on bad password
Contributor
|
I'm not sure what's going on in the diff here but I already did the fix to dismiss the dialog on bad password, see: Other than figuring out why you're not seeing that, LGTM and feel free to merge when Travis goes green. |
samtstern
approved these changes
Sep 30, 2016
Contributor
Author
|
Ah, I hadn't pulled recently enough. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak (#323), switch to auto managed clients where possible and fix dialog hanging around on bad password.