Fix-ups

Author: kentcb

.gitignore

@@ -1,4 +1,4 @@
 bin/
 obj/
 .vscode/
-
+.vs/

FirebaseAdmin/FirebaseAdmin.Tests/Messaging/FirebaseMessagingClientTest.cs

@@ -13,6 +13,7 @@
 // limitations under the License.
 
 using System;
+using System.Linq;
 using System.Net;
 using System.Threading.Tasks;
 using FirebaseAdmin.Tests;
@@ -59,7 +60,7 @@ public async Task SendAsync()
         {
             var handler = new MockMessageHandler()
             {
-                Response = new FirebaseMessagingClient.SendResponse()
+                Response = new FirebaseMessagingClient.SingleMessageResponse()
                 {
                     Name = "test-response",
                 },
@@ -147,6 +148,103 @@ public async Task SendAllAsync()
             Assert.Equal("projects/fir-adminintegrationtests/messages/5903525881088369386", response.Responses[1].MessageId);
         }
 
+        [Fact]
+        public async Task SendAllAsyncWithError()
+        {
+            var rawResponse = @"
+--batch_test-boundary
+Content-Type: application/http
+Content-ID: response-
+
+HTTP/1.1 200 OK
+Content-Type: application/json; charset=UTF-8
+Vary: Origin
+Vary: X-Origin
+Vary: Referer
+
+{
+  ""name"": ""projects/fir-adminintegrationtests/messages/8580920590356323124""
+}
+
+--batch_test-boundary
+Content-Type: application/http
+Content-ID: response-
+
+HTTP/1.1 400 Bad Request
+Content-Type: application/json; charset=UTF-8
+Vary: Origin
+Vary: X-Origin
+Vary: Referer
+
+{
+  ""error"": {
+    ""code"": 400,
+    ""message"": ""The registration token is not a valid FCM registration token"",
+    ""errors"": [
+      {
+        ""message"": ""The registration token is not a valid FCM registration token"",
+        ""domain"": ""global"",
+        ""reason"": ""badRequest""
+      }
+    ],
+    ""status"": ""INVALID_ARGUMENT""
+  }
+}
+
+--batch_test-boundary
+";
+            var handler = new MockMessageHandler()
+            {
+                Response = rawResponse,
+                ApplyContentHeaders = (headers) =>
+                {
+                    headers.Remove("Content-Type");
+                    headers.TryAddWithoutValidation("Content-Type", "multipart/mixed; boundary=batch_test-boundary");
+                },
+            };
+            var factory = new MockHttpClientFactory(handler);
+            var client = new FirebaseMessagingClient(factory, MockCredential, "test-project");
+            var message1 = new Message()
+            {
+                Token = "test-token1",
+            };
+            var message2 = new Message()
+            {
+                Token = "test-token2",
+            };
+            var response = await client.SendAllAsync(new[] { message1, message2 });
+            Assert.Equal(1, response.SuccessCount);
+            Assert.Equal(1, response.FailureCount);
+            Assert.Equal("projects/fir-adminintegrationtests/messages/8580920590356323124", response.Responses[0].MessageId);
+            Assert.NotNull(response.Responses[1].Exception);
+        }
+
+        [Fact]
+        public async Task SendAllAsyncNullList()
+        {
+            var factory = new MockHttpClientFactory(new MockMessageHandler());
+            var client = new FirebaseMessagingClient(factory, MockCredential, "test-project");
+
+            await Assert.ThrowsAsync<ArgumentNullException>(() => client.SendAllAsync(null));
+        }
+
+        [Fact]
+        public async Task SendAllAsyncWithNoMessages()
+        {
+            var factory = new MockHttpClientFactory(new MockMessageHandler());
+            var client = new FirebaseMessagingClient(factory, MockCredential, "test-project");
+            await Assert.ThrowsAsync<ArgumentException>(() => client.SendAllAsync(Enumerable.Empty<Message>()));
+        }
+
+        [Fact]
+        public async Task SendAllAsyncWithTooManyMessages()
+        {
+            var factory = new MockHttpClientFactory(new MockMessageHandler());
+            var client = new FirebaseMessagingClient(factory, MockCredential, "test-project");
+            var messages = Enumerable.Range(0, 101).Select(_ => new Message { Topic = "test-topic" });
+            await Assert.ThrowsAsync<ArgumentException>(() => client.SendAllAsync(messages));
+        }
+
         [Fact]
         public async Task HttpErrorAsync()
         {