Skip to content

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Nov 6, 2025

Due to quirks of how tsdown generates JS code vs how tsc generates JS code, we tweak how logger module is exported to allow it to be mockable.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the logger module's export strategy to enhance its testability. By consolidating logging functions into a dedicated logger object and adjusting its re-export in the main v2 entry point, the changes resolve compilation quirks between tsdown and tsc, making the logger easily mockable for unit testing.

Highlights

  • Logger Mockability: The logger module's export mechanism has been refactored to explicitly export a logger object containing all logging methods. This change directly addresses issues with mocking the logger for testing, particularly when dealing with differences in tsdown and tsc compilation.
  • Export Refactoring: The src/v2/index.ts file now directly re-exports the logger object from ../logger instead of importing and then exporting the entire module. This ensures the newly created mockable logger object is correctly exposed at the top level.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logger export to make it mockable for testing. It achieves this by introducing a logger object in src/logger/index.ts that bundles all logging functions, and then re-exporting this object from the v2 entrypoint. The changes are correct, well-contained, and align with the stated goal in the pull request description. This is a good improvement for testability.

@taeold taeold added this pull request to the merge queue Nov 6, 2025
Merged via the queue into master with commit 352a48f Nov 6, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants