[RTDB] Fix Fatal Exception: FirebaseDatabasePersistenceFailure

[paulb777]

Fix #4493

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

[paulb777]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses a FirebaseDatabasePersistenceFailure fatal exception by setting appropriate file protection attributes when creating the persistence directory. This change allows directory creation even when the device is locked. Additionally, the error reporting is improved by including the underlying NSError in the thrown exception, and the logic is made more robust by logging a warning instead of crashing if setting the 'do not backup' attribute fails. A new unit test has been added to verify the correct file protection attribute is set. The changes are well-implemented and address the issue effectively. I have one minor suggestion to enhance code safety.

[ncooke3]

When the directory already exists, it doesn't sound like the file protection attribute will be updated: true if createIntermediates is set and the directory already exists (from docs).

To handle this case, I think we need to instead set the attribute via this API: https://developer.apple.com/documentation/foundation/filemanager/setattributes(_:ofitematpath:)?language=objc

[paulb777]

Updated. PTAL

[paulb777]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively resolves a FirebaseDatabasePersistenceFailure fatal exception by adjusting the file protection attributes for the persistence directory. The change to NSFileProtectionCompleteUntilFirstUserAuthentication is appropriate and should prevent I/O errors when the app is in the background or the device is locked. Additionally, making error handling for setting backup exclusion and file attributes non-fatal improves the overall robustness of the persistence layer. The accompanying unit test and changelog update are well-done. I have one minor suggestion to enhance the test coverage.

[paulb777]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses a FirebaseDatabasePersistenceFailure fatal exception by improving the robustness of the persistence directory setup. The changes include explicitly setting file protection attributes, making certain setup failures non-fatal, and enhancing error reporting. A comprehensive unit test has been added to validate the new file protection behavior. The changes look solid. I've added one minor suggestion to the new test to further improve its robustness.