Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getAuth comment to make clear that it's idempotent #5255

Merged
merged 4 commits into from
Aug 13, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Aug 6, 2021

Fixes #5254

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2021

⚠️ No Changeset found

Latest commit: d78da3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 added the v9 label Aug 6, 2021
@Feiyang1 Feiyang1 added this to the v9 GA milestone Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 6, 2021

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • ActionCodeURL

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.5 kB
      30.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.6 kB
      42.8 kB
      +186 B (+0.4%)
    • AuthCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.7 kB
      29.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.6 kB
      41.8 kB
      +186 B (+0.4%)
    • EmailAuthCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      31.6 kB
      31.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      43.5 kB
      43.7 kB
      +186 B (+0.4%)
    • EmailAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      33.0 kB
      33.2 kB
      +186 B (+0.6%)
      size-with-ext-deps
      45.1 kB
      45.3 kB
      +186 B (+0.4%)
    • FacebookAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.5 kB
      34.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.4 kB
      46.6 kB
      +186 B (+0.4%)
    • GithubAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.5 kB
      34.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.4 kB
      46.6 kB
      +186 B (+0.4%)
    • GoogleAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.5 kB
      34.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.4 kB
      46.6 kB
      +186 B (+0.4%)
    • OAuthCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      31.6 kB
      31.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      43.5 kB
      43.6 kB
      +186 B (+0.4%)
    • OAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      35.4 kB
      35.5 kB
      +186 B (+0.5%)
      size-with-ext-deps
      47.3 kB
      47.4 kB
      +186 B (+0.4%)
    • PhoneAuthCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      31.7 kB
      31.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      43.6 kB
      43.8 kB
      +186 B (+0.4%)
    • PhoneAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      33.4 kB
      33.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      45.3 kB
      45.5 kB
      +186 B (+0.4%)
    • PhoneMultiFactorGenerator

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.3 kB
      30.5 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.2 kB
      42.4 kB
      +186 B (+0.4%)
    • RecaptchaVerifier

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      35.8 kB
      36.0 kB
      +186 B (+0.5%)
      size-with-ext-deps
      47.7 kB
      47.9 kB
      +186 B (+0.4%)
    • SAMLAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      35.7 kB
      35.9 kB
      +186 B (+0.5%)
      size-with-ext-deps
      47.6 kB
      47.8 kB
      +186 B (+0.4%)
    • TwitterAuthProvider

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.5 kB
      34.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.4 kB
      46.6 kB
      +186 B (+0.4%)
    • applyActionCode

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.6 kB
      29.8 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.5 kB
      41.7 kB
      +186 B (+0.4%)
    • checkActionCode

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.6 kB
      30.8 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.5 kB
      42.7 kB
      +186 B (+0.4%)
    • confirmPasswordReset

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.7 kB
      29.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.6 kB
      41.8 kB
      +186 B (+0.4%)
    • connectAuthEmulator

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      31.2 kB
      31.3 kB
      +186 B (+0.6%)
      size-with-ext-deps
      43.0 kB
      43.2 kB
      +186 B (+0.4%)
    • createUserWithEmailAndPassword

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.6 kB
      30.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.4 kB
      42.6 kB
      +186 B (+0.4%)
    • deleteUser

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.4%)
    • fetchSignInMethodsForEmail

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.9 kB
      30.1 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.8 kB
      42.0 kB
      +186 B (+0.4%)
    • getAdditionalUserInfo

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.7 kB
      30.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.6 kB
      42.8 kB
      +186 B (+0.4%)
    • getAuth

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      60.9 kB
      61.1 kB
      +253 B (+0.4%)
      size-with-ext-deps
      73.1 kB
      73.4 kB
      +253 B (+0.3%)
    • getIdToken

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.4%)
    • getIdTokenResult

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.5%)
    • getMultiFactorResolver

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      32.2 kB
      32.4 kB
      +186 B (+0.6%)
      size-with-ext-deps
      44.1 kB
      44.3 kB
      +186 B (+0.4%)
    • getRedirectResult

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      37.0 kB
      37.1 kB
      +186 B (+0.5%)
      size-with-ext-deps
      48.9 kB
      49.1 kB
      +186 B (+0.4%)
    • initializeAuth

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.6 kB
      29.8 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.5 kB
      41.7 kB
      +186 B (+0.4%)
    • isSignInWithEmailLink

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.6 kB
      30.8 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.7 kB
      42.9 kB
      +186 B (+0.4%)
    • linkWithCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.4 kB
      30.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.3 kB
      42.5 kB
      +186 B (+0.4%)
    • linkWithPhoneNumber

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.2 kB
      34.4 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.1 kB
      46.3 kB
      +186 B (+0.4%)
    • linkWithPopup

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      40.3 kB
      40.5 kB
      +186 B (+0.5%)
      size-with-ext-deps
      52.2 kB
      52.4 kB
      +186 B (+0.4%)
    • linkWithRedirect

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      35.5 kB
      35.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      47.4 kB
      47.6 kB
      +186 B (+0.4%)
    • multiFactor

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      31.5 kB
      31.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      43.4 kB
      43.6 kB
      +186 B (+0.4%)
    • onAuthStateChanged

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.4 kB
      41.5 kB
      +186 B (+0.4%)
    • onIdTokenChanged

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.4 kB
      41.5 kB
      +186 B (+0.4%)
    • parseActionCodeURL

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.5 kB
      30.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.7 kB
      42.9 kB
      +186 B (+0.4%)
    • reauthenticateWithCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      31.0 kB
      31.2 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.9 kB
      43.1 kB
      +186 B (+0.4%)
    • reauthenticateWithPhoneNumber

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.7 kB
      34.9 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.7 kB
      46.8 kB
      +186 B (+0.4%)
    • reauthenticateWithPopup

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      40.3 kB
      40.5 kB
      +186 B (+0.5%)
      size-with-ext-deps
      52.2 kB
      52.4 kB
      +186 B (+0.4%)
    • reauthenticateWithRedirect

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      35.2 kB
      35.4 kB
      +186 B (+0.5%)
      size-with-ext-deps
      47.2 kB
      47.3 kB
      +186 B (+0.4%)
    • reload

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.5%)
    • sendEmailVerification

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.5 kB
      30.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.4 kB
      42.5 kB
      +186 B (+0.4%)
    • sendPasswordResetEmail

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.4 kB
      30.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.3 kB
      42.5 kB
      +186 B (+0.4%)
    • sendSignInLinkToEmail

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.4 kB
      30.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.3 kB
      42.5 kB
      +186 B (+0.4%)
    • setPersistence

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.4%)
    • signInAnonymously

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.7 kB
      30.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.6 kB
      42.8 kB
      +186 B (+0.4%)
    • signInWithCredential

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.8 kB
      31.0 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.7 kB
      42.9 kB
      +186 B (+0.4%)
    • signInWithCustomToken

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.5 kB
      30.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.4 kB
      42.6 kB
      +186 B (+0.4%)
    • signInWithEmailAndPassword

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.5 kB
      34.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.6 kB
      46.8 kB
      +186 B (+0.4%)
    • signInWithEmailLink

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.7 kB
      34.9 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.8 kB
      47.0 kB
      +186 B (+0.4%)
    • signInWithPhoneNumber

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.5 kB
      34.7 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.4 kB
      46.6 kB
      +186 B (+0.4%)
    • signInWithPopup

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      40.3 kB
      40.5 kB
      +186 B (+0.5%)
      size-with-ext-deps
      52.2 kB
      52.4 kB
      +186 B (+0.4%)
    • signInWithRedirect

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      35.0 kB
      35.1 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.9 kB
      47.0 kB
      +186 B (+0.4%)
    • signOut

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.5%)
    • unlink

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.0 kB
      30.2 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.9 kB
      42.1 kB
      +186 B (+0.4%)
    • updateCurrentUser

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.4 kB
      41.5 kB
      +186 B (+0.4%)
    • updateEmail

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.7 kB
      29.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.6 kB
      41.8 kB
      +186 B (+0.4%)
    • updatePassword

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.7 kB
      29.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.6 kB
      41.8 kB
      +186 B (+0.4%)
    • updatePhoneNumber

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.2 kB
      30.4 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.1 kB
      42.3 kB
      +186 B (+0.4%)
    • updateProfile

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.9 kB
      30.1 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.8 kB
      42.0 kB
      +186 B (+0.4%)
    • useDeviceLanguage

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.4%)
    • verifyBeforeUpdateEmail

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.5 kB
      30.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.4 kB
      42.6 kB
      +186 B (+0.4%)
    • verifyPasswordResetCode

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      30.7 kB
      30.9 kB
      +186 B (+0.6%)
      size-with-ext-deps
      42.6 kB
      42.8 kB
      +186 B (+0.4%)
    • ActionCodeOperation

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.7 kB
      29.8 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.5 kB
      41.7 kB
      +186 B (+0.4%)
    • AuthErrorCodes

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      34.1 kB
      34.3 kB
      +186 B (+0.5%)
      size-with-ext-deps
      46.0 kB
      46.1 kB
      +186 B (+0.4%)
    • FactorId

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.5%)
    • OperationType

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.4 kB
      41.6 kB
      +186 B (+0.4%)
    • ProviderId

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.5 kB
      29.7 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.4 kB
      41.6 kB
      +186 B (+0.4%)
    • SignInMethod

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.6 kB
      29.8 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.5 kB
      41.6 kB
      +186 B (+0.4%)
    • browserLocalPersistence

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      32.7 kB
      32.9 kB
      +218 B (+0.7%)
      size-with-ext-deps
      44.7 kB
      44.9 kB
      +218 B (+0.5%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      53.3 kB
      53.5 kB
      +218 B (+0.4%)
      size-with-ext-deps
      65.4 kB
      65.6 kB
      +218 B (+0.3%)
    • browserSessionPersistence

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      32.7 kB
      32.9 kB
      +218 B (+0.7%)
      size-with-ext-deps
      44.7 kB
      44.9 kB
      +218 B (+0.5%)
    • debugErrorMap

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      40.3 kB
      40.5 kB
      +186 B (+0.5%)
      size-with-ext-deps
      52.2 kB
      52.4 kB
      +186 B (+0.4%)
    • inMemoryPersistence

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.5%)
    • indexedDBLocalPersistence

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      36.8 kB
      37.0 kB
      +218 B (+0.6%)
      size-with-ext-deps
      48.7 kB
      48.9 kB
      +218 B (+0.4%)
    • prodErrorMap

      Size Table

      TypeBase (35865ee)Head (cd382be)Diff
      size
      29.4 kB
      29.6 kB
      +186 B (+0.6%)
      size-with-ext-deps
      41.3 kB
      41.5 kB
      +186 B (+0.5%)

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 6, 2021

Binary Size Report

Affected SDKs

  • @firebase/rules-unit-testing

    Type Base (35865ee) Head (cd382be) Diff
    main 15.3 kB 15.4 kB +60 B (+0.4%)

Test Logs

@Feiyang1 Feiyang1 assigned egilmorez and kevinthecheung and unassigned sam-gc and egilmorez Aug 6, 2021
@@ -121,7 +121,8 @@ export { browserPopupRedirectResolver } from './src/platform_browser/popup_redir
export { PhoneMultiFactorGenerator } from './src/platform_browser/mfa/assertions/phone';

/**
* Initializes an Auth instance with platform specific default dependencies.
* Return the existing Auth instance that is associated with the provided {@link @firebase/app#FirebaseApp}.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinthecheung can you please take a look at it when you have a moment?

Feiyang1 and others added 3 commits August 10, 2021 14:53
@Feiyang1 Feiyang1 merged commit 064e1ca into master Aug 13, 2021
@Feiyang1 Feiyang1 deleted the fei-getauth-dco branch August 13, 2021 17:53
@firebase firebase locked and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants