diff --git a/CHANGELOG.md b/CHANGELOG.md index 68edae115db..622a68b8557 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ - Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584) - Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562) - Use Web Framework's well known version range in `firebase init hosting`. (#6562) +- Limit Web Framework's generated Cloud Function name to 20 characters, fixing deploys for some. (#6260) diff --git a/src/frameworks/index.ts b/src/frameworks/index.ts index 01b8d21f665..0bbbb4f1241 100644 --- a/src/frameworks/index.ts +++ b/src/frameworks/index.ts @@ -175,7 +175,8 @@ export async function prepareFrameworks( ); } const getProjectPath = (...args: string[]) => join(projectRoot, source, ...args); - const functionId = `ssr${site.toLowerCase().replace(/-/g, "")}`; + // Combined traffic tag (19 chars) and functionId cannot exceed 46 characters. + const functionId = `ssr${site.toLowerCase().replace(/-/g, "").substring(0, 20)}`; const usesFirebaseAdminSdk = !!findDependency("firebase-admin", { cwd: getProjectPath() }); const usesFirebaseJsSdk = !!findDependency("@firebase/app", { cwd: getProjectPath() }); if (usesFirebaseAdminSdk) {