From 0fb3f1618f8b66d2126332f559556436c66db678 Mon Sep 17 00:00:00 2001 From: Alex Astrum Date: Tue, 15 Aug 2023 16:02:37 -0400 Subject: [PATCH 1/2] Limit web frameworks generated functionId to 20 chars max --- src/frameworks/index.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/frameworks/index.ts b/src/frameworks/index.ts index b25bc4f49b3..1f329ad774c 100644 --- a/src/frameworks/index.ts +++ b/src/frameworks/index.ts @@ -175,7 +175,8 @@ export async function prepareFrameworks( ); } const getProjectPath = (...args: string[]) => join(projectRoot, source, ...args); - const functionId = `ssr${site.toLowerCase().replace(/-/g, "")}`; + // Combined traffic tag (19 chars) and functionId cannot exceed 46 characters. + const functionId = `ssr${site.toLowerCase().replace(/-/g, "").substring(0, 20)}`; const usesFirebaseAdminSdk = !!findDependency("firebase-admin", { cwd: getProjectPath() }); const usesFirebaseJsSdk = !!findDependency("@firebase/app", { cwd: getProjectPath() }); if (usesFirebaseAdminSdk) { From ededd2de1d6fcab92a36dab6c08ab35c8a55bfef Mon Sep 17 00:00:00 2001 From: James Daniels Date: Thu, 7 Dec 2023 11:09:15 -0500 Subject: [PATCH 2/2] Add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 68edae115db..622a68b8557 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ - Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584) - Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562) - Use Web Framework's well known version range in `firebase init hosting`. (#6562) +- Limit Web Framework's generated Cloud Function name to 20 characters, fixing deploys for some. (#6260)