Fix/Revamp network-for-clones documentation #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4848 +/- ##
=======================================
Coverage 84.01% 84.01%
=======================================
Files 251 251
Lines 28019 28019
=======================================
Hits 23541 23541
Misses 4478 4478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
force-pushed
the
fix-network-clones
branch
3 times, most recently
from
5dca274 to
3e25bc3
Compare
pb8o
added
the
Status: Awaiting author
pb8o
force-pushed
the
fix-network-clones
branch
from
3e25bc3 to
67110d7
Compare
There's also some more packages that are required since the devctr upgrade to Ubuntu 24.04. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
validate_spec is deprecated
DeprecationWarning: validate_spec shortcut is deprecated.
Use validate instead.
Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Address the discussion in firecracker-microvm#4720 - Reflect that the doc is just an example. - Fix the doc so that it works. - Split the ingress setup as that is a specific requirement that may not always be required, and complicates the implementation. - Also simplify the test framework helpers since on revisiting some of the iptables rules were not needed. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
force-pushed
the
fix-network-clones
branch
from
67110d7 to
7a5d938
Compare
pb8o
added
Status: Awaiting review
Manciukic
approved these changes
Oct 14, 2024
kalyazin
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
Address the discussion in #4720
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.