This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
Flock Agent tells the server when twig settings change, or server is enabled/disabled #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change, to avoid pointless keybase notifications
…ith enable_undecided_twigs and update_twig_status, to enable/disable twigs in bulk; also replace the flock log types TWIG_ENABLED and TWIG_DISABLED with TWIGS_ENABLED and TWIGS_DISABLED
…_twig() for each twig
… when the use_server setting is changed
simonft
suggested changes
Oct 18, 2019
…strings instead; make flock logs store timestamps in milliseconds instead of seconds
|
Ok @simonft I think I've addressed everything in your review now |
simonft
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #38.
This introduces a new type of "flock logs", a log message that's just about Flock and not an osquery log. There are four types of flock logs so far: server_enabled, server_disabled, twigs_enabled, and twigs_disabled. They get logged to disk, and once a minute when the daemon tries submitting osquery logs to the server, it also tries submitting flock logs. (It works this way so that the server ends up getting flock logs even if they were generated when the daemon can't reach the server, like if wifi is disabled.)
This also does a bit of refactoring between the GUI and the daemon, removing unnecessary routes and making it so the GUI can send a single request to update the status of all twigs instead of having to send a separate request per twig.