Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patchted version of youtube-dl #49

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

nullket
Copy link
Collaborator

@nullket nullket commented Jan 4, 2022

This "fixes" the youtube throttling for python2 user.

I have forked dirkf's youtube-dl version in which he has patched youtube. The fork is under my namespace, thus the repo does not automatically update and is therefore less error prone in terms of unintended changes (take down of the repo, malicious code pushes etc.) The repo can be found here.

I made some smaller adjustments to the update script/workflow in order to allow the specification of a desired branch (in case of youtube-dlp it is still HEAD to follow master/main/development or whatever the "main" branch is called.

I would see this temporary:

  • If youtube-dl comes back we should switch back
  • If not it is temporary as in terms of nobody uses kodi leia at one point anymore.

@firsttris ready to be merged but I would not be to sad if you would disagree with the workaround.

… and changed to youtube-dl to a temporary fork to avoid throttling
@nullket nullket requested a review from firsttris January 4, 2022 18:46
@firsttris
Copy link
Owner

good work, i like it

@firsttris firsttris merged commit 9fa3cd1 into firsttris:master Jan 4, 2022
@nullket nullket mentioned this pull request Jan 4, 2022
@nullket nullket deleted the youtube-dl-patched-repo branch February 5, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants