Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement Jellyfish #577

Closed
zicklag opened this issue Jan 19, 2023 · 0 comments · Fixed by #895
Closed

Re-implement Jellyfish #577

zicklag opened this issue Jan 19, 2023 · 0 comments · Fixed by #895
Labels
good first issue Good for newcomers help wanted Extra attention is needed topic:item Interactive items, e.g. equipment

Comments

@zicklag
Copy link
Member

zicklag commented Jan 19, 2023

Re-implement jellyfish from here: #36.

The mind-controlling aspect of the jellyfish should probably be implemented as a new player state.

When the item is triggered, it will move the player to a new state where the player doesn't respond directly to user inputs, but the newly spawned jellyfish is.
@zicklag zicklag added enhancement help wanted Extra attention is needed good first issue Good for newcomers topic:item Interactive items, e.g. equipment labels Jan 19, 2023
@zicklag zicklag mentioned this issue Jan 19, 2023
Open
@nelson137 nelson137 mentioned this issue Jan 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2024
@nelson137
feat: Reimplement Jellyfish (#895)
fb1e34a 
Hi 👋 I've been wanting to contribute to jumpy for a bit so I
started tinkering with the jellyfish item.. and it went more smoothly
than I thought! I think I met all the original requirements but there
were a few small things I wasn't certain about (see bottom).

Closes #577

## Behavior

- Item behaves like the musket:
  - It has a limited amount of ammo: 1 use
  - It reloads immediately when dropped
- Players can only use the jellyfish while idle (i.e. can't be walking,
falling, etc.)
- The flappy jellyfish explodes if any of the following happen:
  - It goes outside the map
  - It collides with a player
  - The driver dies

## Outstanding Questions

- Is `LoadedMap::is_out_of_bounds` fine for explosion on out of bounds?
  - Is there a better way to detect this?
- Should the explosion have an emote region?
  - e.g. the sword creates one 3.5x larger than the damage region
- The item asset has 2 frames but I only used 1
  - Should it be animating while grabbed or on the ground?
- Should the jellyfish go on the player's head while driving?
  - I tried but couldn't get the sprite to rotate
@nelson137 nelson137 mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed topic:item Interactive items, e.g. equipment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Reimplement Jellyfish nelson137/jumpy
1 participant
@zicklag