Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: incorrect collision when player slides into the right side of a solid #910

Closed
nelson137 opened this issue Jan 23, 2024 · 0 comments · Fixed by #911
Closed

bug: incorrect collision when player slides into the right side of a solid #910

nelson137 opened this issue Jan 23, 2024 · 0 comments · Fixed by #911

Comments

@nelson137
Copy link
Contributor

Description

When a player slides into the right side of a solid object they are stopped just before it, leaving a gap.

solids.mp4

To Reproduce

  1. Walk left toward a solid object
  2. Start sliding

Expected Behavior

Player stops up against the collider -- there should be no gap when sliding into an object.

Additional Context

This bug is not present for the left sides of objects.

Log Messages

No response
@nelson137 nelson137 mentioned this issue Jan 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2024
@nelson137
fix: sliding collisions (#911)
3e99ea2 
Closes #910

This was more simple than I expected. When a sliding player collides
with something and stops moving, the transform adjustment to stand up
didn't take into account the direction the player is facing.


https://github.com/fishfolk/jumpy/assets/25290530/aecf7cf4-72ef-427b-8f16-73000f43ad5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sliding collisions nelson137/jumpy
1 participant
@nelson137